Catch registry exceptions and log them

Author: shana

src/GitHub.Exports/GitHub.Exports.csproj

@@ -110,6 +110,7 @@
     <Compile Include="Helpers\NotificationAwareObject.cs" />
     <Compile Include="Services\Connection.cs" />
     <Compile Include="Services\ITeamExplorerServiceHolder.cs" />
+    <Compile Include="Services\Logger.cs" />
     <Compile Include="Services\Services.cs" />
     <Compile Include="Services\VSServices.cs" />
     <Compile Include="Models\IConnection.cs" />

…c/GitHub.VisualStudio/Services/Logger.cs src/GitHub.Exports/Services/Logger.cssrc/GitHub.VisualStudio/Services/Logger.cs renamed to src/GitHub.Exports/Services/Logger.cs src/GitHub.VisualStudio/Services/Logger.cs renamed to src/GitHub.Exports/Services/Logger.cs

@@ -1,11 +1,9 @@
 using GitHub.Info;
 using System;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
 using System.IO;
 using System.Text;
-using System.Threading;
 
 namespace GitHub.VisualStudio
 {

src/GitHub.Exports/Services/VSServices.cs

@@ -61,7 +61,7 @@ public string GetLocalClonePathFromGitProvider()
             }
             catch (Exception ex)
             {
-                Debug.Fail(ex.ToString());
+                VsOutputLogger.WriteLine(string.Format(CultureInfo.CurrentCulture, "Error loading the default cloning path from the registry '{0}'", ex));
             }
             return ret;
         }
@@ -91,7 +91,15 @@ public string GetActiveRepoPath()
 
         public IEnumerable<ISimpleRepositoryModel> GetKnownRepositories()
         {
-            return PokeTheRegistryForRepositoryList();
+            try
+            {
+                return PokeTheRegistryForRepositoryList();
+            }
+            catch (Exception ex)
+            {
+                VsOutputLogger.WriteLine(string.Format(CultureInfo.CurrentCulture, "Error loading the repository list from the registry '{0}'", ex));
+                return Enumerable.Empty<ISimpleRepositoryModel>();
+            }
         }
 
         const string TEGitKey = @"Software\Microsoft\VisualStudio\14.0\TeamFoundation\GitSourceControl";

src/GitHub.VisualStudio/GitHub.VisualStudio.csproj

@@ -225,7 +225,6 @@
     <Compile Include="Helpers\Colors.cs" />
     <Compile Include="Helpers\Constants.cs" />
     <Compile Include="Services\ConnectionManager.cs" />
-    <Compile Include="Services\Logger.cs" />
     <Compile Include="Services\Program.cs" />
     <Compile Include="Services\SharedResources.cs" />
     <Compile Include="Settings.cs" />