Fix string culture warnings.

Fixes CA1304, CA1305, CA1307, CA1308 and CA1309.

Author: grokys

src/GitHub.App/Services/PullRequestEditorService.cs

@@ -232,12 +232,12 @@ await pullRequestService.ExtractToTempFile(
 
                 var leftText = diffViewer.LeftView.TextBuffer.CurrentSnapshot.GetText();
                 var rightText = diffViewer.RightView.TextBuffer.CurrentSnapshot.GetText();
-                if (leftText == string.Empty)
+                if (leftText.Length == 0)
                 {
                     // Don't show LeftView when empty.
                     diffViewer.ViewMode = DifferenceViewMode.RightViewOnly;
                 }
-                else if (rightText == string.Empty)
+                else if (rightText.Length == 0)
                 {
                     // Don't show RightView when empty.
                     diffViewer.ViewMode = DifferenceViewMode.LeftViewOnly;

src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs

@@ -1,6 +1,7 @@
 using System;
 using System.ComponentModel.Composition;
 using System.ComponentModel.Design;
+using System.Globalization;
 using System.Linq;
 using System.Reactive;
 using System.Reactive.Linq;
@@ -253,29 +254,29 @@ public async Task NavigateTo(Uri uri)
             {
                 var owner = match.Groups["owner"].Value;
                 var repo = match.Groups["repo"].Value;
-                var number = int.Parse(match.Groups["number"].Value);
+                var number = int.Parse(match.Groups["number"].Value, CultureInfo.InvariantCulture);
                 await ShowPullRequest(owner, repo, number);
             }
             else if ((match = pullNewReviewUri.Match(uri.AbsolutePath))?.Success == true)
             {
                 var owner = match.Groups["owner"].Value;
                 var repo = match.Groups["repo"].Value;
-                var number = int.Parse(match.Groups["number"].Value);
+                var number = int.Parse(match.Groups["number"].Value, CultureInfo.InvariantCulture);
                 await ShowPullRequestReviewAuthoring(owner, repo, number);
             }
             else if ((match = pullUserReviewsUri.Match(uri.AbsolutePath))?.Success == true)
             {
                 var owner = match.Groups["owner"].Value;
                 var repo = match.Groups["repo"].Value;
-                var number = int.Parse(match.Groups["number"].Value);
+                var number = int.Parse(match.Groups["number"].Value, CultureInfo.InvariantCulture);
                 var login = match.Groups["login"].Value;
                 await ShowPullRequestReviews(owner, repo, number, login);
             }
             else if ((match = pullCheckRunsUri.Match(uri.AbsolutePath))?.Success == true)
             {
                 var owner = match.Groups["owner"].Value;
                 var repo = match.Groups["repo"].Value;
-                var number = int.Parse(match.Groups["number"].Value);
+                var number = int.Parse(match.Groups["number"].Value, CultureInfo.InvariantCulture);
                 var id = match.Groups["id"].Value;
 
                 await ShowPullRequestCheckRun(owner, repo, number, id);

src/GitHub.App/ViewModels/GitHubPane/IssueListViewModelBase.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Reactive;
@@ -252,7 +253,7 @@ void FilterChanged()
 
                 if (numberFilter == 0)
                 {
-                    stringFilter = SearchQuery.ToUpper();
+                    stringFilter = SearchQuery.ToUpper(CultureInfo.CurrentCulture);
                 }
             }
             else
@@ -280,7 +281,7 @@ bool FilterItem(object o)
                     }
                     else
                     {
-                        result = item.Title.ToUpper().Contains(stringFilter);
+                        result = item.Title.ToUpper(CultureInfo.InvariantCulture).Contains(stringFilter);
                     }
                 }
             }

src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs

@@ -370,6 +370,7 @@ public async Task Load(PullRequestDetailModel pullRequest)
                     if (pullEnabled)
                     {
                         pullToolTip = string.Format(
+                            CultureInfo.InvariantCulture,
                             Resources.PullRequestDetailsPullToolTip,
                             IsFromFork ? Resources.Fork : Resources.Remote,
                             SourceBranchDisplayName);
@@ -382,6 +383,7 @@ public async Task Load(PullRequestDetailModel pullRequest)
                     if (pushEnabled)
                     {
                         pushToolTip = string.Format(
+                            CultureInfo.InvariantCulture,
                             Resources.PullRequestDetailsPushToolTip,
                             IsFromFork ? Resources.Fork : Resources.Remote,
                             SourceBranchDisplayName);
@@ -396,16 +398,22 @@ public async Task Load(PullRequestDetailModel pullRequest)
                     }
 
                     var submodulesToSync = await pullRequestsService.CountSubmodulesToSync(LocalRepository);
-                    var syncSubmodulesToolTip = string.Format(Resources.SyncSubmodules, submodulesToSync);
+                    var syncSubmodulesToolTip = string.Format(CultureInfo.InvariantCulture, Resources.SyncSubmodules, submodulesToSync);
 
                     UpdateState = new UpdateCommandState(divergence, pullEnabled, pushEnabled, pullToolTip, pushToolTip, syncSubmodulesToolTip, submodulesToSync);
                     CheckoutState = null;
                 }
                 else
                 {
                     var caption = localBranches.Count > 0 ?
-                        string.Format(Resources.PullRequestDetailsCheckout, localBranches.First().DisplayName) :
-                        string.Format(Resources.PullRequestDetailsCheckoutTo, await pullRequestsService.GetDefaultLocalBranchName(LocalRepository, Model.Number, Model.Title));
+                        string.Format(
+                            CultureInfo.InvariantCulture,
+                            Resources.PullRequestDetailsCheckout,
+                            localBranches.First().DisplayName) :
+                        string.Format(
+                            CultureInfo.InvariantCulture,
+                            Resources.PullRequestDetailsCheckoutTo,
+                            await pullRequestsService.GetDefaultLocalBranchName(LocalRepository, Model.Number, Model.Title));
                     var clean = await pullRequestsService.IsWorkingDirectoryClean(LocalRepository);
                     string disabled = null;
 

src/GitHub.App/ViewModels/UserFilterViewModel.cs

@@ -146,7 +146,10 @@ public int Compare(object x, object y)
             {
                 if (x == owner.ersatzUser) return -1;
                 if (y == owner.ersatzUser) return 1;
-                return ((IActorViewModel)x).Login.CompareTo(((IActorViewModel)y).Login);
+                return string.Compare(
+                    ((IActorViewModel)x).Login,
+                    ((IActorViewModel)y).Login,
+                    StringComparison.Ordinal);
             }
         }
     }

src/GitHub.Exports/Models/CommitMessage.cs

@@ -39,8 +39,8 @@ public bool Equals(CommitMessage other)
                 return false;
             }
 
-            return string.Equals(Summary, other.Summary)
-                && string.Equals(Details, other.Details);
+            return string.Equals(Summary, other.Summary, StringComparison.Ordinal)
+                && string.Equals(Details, other.Details, StringComparison.Ordinal);
         }
 
         public override bool Equals(object obj)

src/GitHub.Exports/Models/DiffUtilities.cs

@@ -4,6 +4,7 @@
 using System.Text.RegularExpressions;
 using System.Diagnostics.CodeAnalysis;
 using GitHub.Extensions;
+using System.Globalization;
 
 #pragma warning disable CA1034 // Nested types should not be visible
 
@@ -39,8 +40,8 @@ public static IEnumerable<DiffChunk> ParseFragment(string diff)
 
                     chunk = new DiffChunk
                     {
-                        OldLineNumber = oldLine = int.Parse(headerMatch.Groups[1].Value),
-                        NewLineNumber = newLine = int.Parse(headerMatch.Groups[2].Value),
+                        OldLineNumber = oldLine = int.Parse(headerMatch.Groups[1].Value, CultureInfo.InvariantCulture),
+                        NewLineNumber = newLine = int.Parse(headerMatch.Groups[2].Value, CultureInfo.InvariantCulture),
                         DiffLine = diffLine,
                     };
                 }

src/GitHub.Exports/Models/LocalRepositoryModel.cs

@@ -55,9 +55,9 @@ public bool Equals(LocalRepositoryModel other)
             if (ReferenceEquals(this, other))
                 return true;
             return other != null &&
-                string.Equals(Name, other.Name) &&
-                string.Equals(Owner, other.Owner) &&
-                string.Equals(CloneUrl, other.CloneUrl) &&
+                string.Equals(Name, other.Name, StringComparison.Ordinal) &&
+                string.Equals(Owner, other.Owner, StringComparison.Ordinal) &&
+                string.Equals(CloneUrl, other.CloneUrl, StringComparison.Ordinal) &&
                 string.Equals(LocalPath?.TrimEnd('\\'), other.LocalPath?.TrimEnd('\\'), StringComparison.CurrentCultureIgnoreCase);
         }
 

src/GitHub.InlineReviews/Services/PullRequestSessionManager.cs

@@ -236,7 +236,7 @@ async Task<PullRequestSession> GetSessionInternal(string owner, string name, int
 
             PullRequestSession session = null;
             WeakReference<PullRequestSession> weakSession;
-            var key = Tuple.Create(owner.ToLowerInvariant(), number);
+            var key = Tuple.Create(owner.ToUpperInvariant(), number);
 
             if (sessions.TryGetValue(key, out weakSession))
             {

src/GitHub.TeamFoundation.14/Base/EnsureLoggedInSection.cs

@@ -54,7 +54,7 @@ async Task CheckLogin()
             bool loggedIn = await ConnectionManager.IsLoggedIn(add);
             if (!loggedIn)
             {
-                var msg = string.Format(CultureInfo.CurrentUICulture, Resources.NotLoggedInMessage, add.Title, add.Title);
+                var msg = string.Format(CultureInfo.CurrentCulture, Resources.NotLoggedInMessage, add.Title, add.Title);
                 teServices.ShowMessage(
                     msg,
                     new Primitives.RelayCommand(_ => dialogService.ShowLoginDialog())