Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up existing logging statements by replacing fmt calls with log calls and adds a Docker build & test workflow.
- Update logging for improved clarity and consistency
- Add Docker image build/push workflow and a build/test workflow
- Make minor spelling corrections in log messages and comments
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/verifier/verifier.go | Replaced fmt with log for error reporting |
| pkg/verifier/multi.go | Updated error logging messages with log functions |
| pkg/provider/provider.go | Consistent log usage in provider validation errors |
| pkg/authn/provider.go | Updated logging related to keychain configuration |
| cmd/cver/cver.go | Logging adjustments in the CLI verification app |
| cmd/aaop/aaop.go | Replaced fmt with log and noted minor spelling issues |
| .github/workflows/docker.yaml | Added workflow to build and push Docker image |
| .github/workflows/build.yml | Added build and test workflow with a typo in a step name |
Files not reviewed (2)
- Dockerfile: Language not supported
- Makefile: Language not supported
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
codysoyland
reviewed
Apr 8, 2025
codysoyland
reviewed
Apr 8, 2025
codysoyland
reviewed
Apr 8, 2025
codysoyland
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/package-security/issues/2848
Closes https://github.com/github/package-security/issues/2849