Skip to content

sync fetchResult example with code #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francinelucca merged 2 commits into from
Mar 4, 2025
Merged

sync fetchResult example with code #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4d99ef
sync fetchResult example with code
jdanyow Feb 25, 2025
9c5bda8
Update index.html
jdanyow Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ As an example:

## Properties

- `fetchResult` you can override the default method used to query for results by overriding this property: `document.querySelector('auto-complete').fetchResult = async (el, url) => (await fetch(url)).text()`
- `fetchResult` you can override the default method used to query for results by overriding this property: `document.querySelector('auto-complete').fetchResult = async (url) => (await fetch(url)).text()`

## Events

Expand Down
6 changes: 3 additions & 3 deletions examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@
}
return Promise.resolve(new Response(robotsList));
}
// fetchResult must be a function that return a Promise of string and that accepts as parameters an element and an URL
document.querySelector("auto-complete#custom-fetching-method").fetchResult = async (el, url) => (await fetch(url)).text();
// fetchResult must be a function that return a Promise of string and that accepts as parameters a URL
document.querySelector("auto-complete#custom-fetching-method").fetchResult = async (url) => (await fetch(url)).text();
</script>

<form>
Expand All @@ -129,4 +129,4 @@
<script type="module" src="https://unpkg.com/@github/auto-complete-element@latest/dist/bundle.js"></script>
</body>
</html>