Skip to content

Conversation

@aaronpowell
Copy link
Contributor

  • Fixing line endings and removing dead code
  • Missing descriptions due to line endings
  • Enforcing that the line endings should be LF

Copilot AI review requested due to automatic review settings July 3, 2025 02:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes on LF line endings, removes dead code related to chat modes generation, and adds CI enforcement.

  • Removed outdated logic for regenerating the custom chat modes section in update-readme.js.
  • Added a Development Configuration section in README.md to document LF enforcement.
  • Introduced a GitHub Actions workflow to block CRLF line endings in markdown files.

Reviewed Changes

Copilot reviewed 3 out of 12 changed files in this pull request and generated no comments.

File Description
update-readme.js Stripped out obsolete chat modes list regeneration code
README.md Added development config section explaining line endings policy
.github/workflows/check-line-endings.yml New workflow to detect and fail on CRLF in markdown files
Files not reviewed (5)
  • .editorconfig: Language not supported
  • .gitattributes: Language not supported
  • .vscode/extensions.json: Language not supported
  • .vscode/settings.json: Language not supported
  • scripts/fix-line-endings.sh: Language not supported
Comments suppressed due to low confidence (2)

update-readme.js:355

  • The removal of the entire branch handling chat modes insertion appears to drop all logic for updating the README with custom chat modes. If this is intentional, please ensure that you update or remove any related references elsewhere, and add tests to cover the new behavior; otherwise, restore the necessary parts to maintain functionality.
  return `${TEMPLATES.chatmodesSection}\n\n${chatmodesContent}\n${TEMPLATES.chatmodesUsage}`;

.github/workflows/check-line-endings.yml:17

  • [nitpick] To make the check more robust, consider using git grep -I --files-with-matches '\r' -- '*.md' or piping find into xargs grep, which handles filenames with spaces and scales better on large repositories.
          ! grep -l $'\r' $(find . -name "*.md")

aaronpowell and others added 3 commits July 3, 2025 12:07
…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@aaronpowell aaronpowell merged commit 04c5757 into main Jul 3, 2025
5 checks passed
@aaronpowell aaronpowell deleted the enforcing-style-rules branch July 3, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants