-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Appendix/table of all repo licenses; closes #388 #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wow. I like that a lot. 😄 |
|
This is wonderful. Eventually we should be able to apply filters to the table and sort the rows, but for a start it's great! I might submit styling tweaks later on when I get the time, but I like how it looks already :) |
|
I'm going to go ahead and merge this. Definitely welcome pull requests to make it look better or to allow sorting, etc. Note that I've not made the license property tooltips you can see eg in /licenses or on individual license pages work (hover over eg "commercial use" on one of those pages). The CSS and Javascript (relevant files are |
|
Great work! @ #406 (comment) So where is http://choosealicense.com/appendix/ now linked from ... I could not find it on the home page - so either I am blind or its no there or the discover-ability towards that page/link maybe isn't good. |
|
The headers could/should link to the feature pages (e.g. "patent use", "hold liable") etc. |
|
@ionas thanks. It's linked from /about. User can navigate from http://choosealicense.com/ to http://choosealicense.com/licenses/ to (linked at bottom) http://choosealicense.com/about/ to http://choosealicense.com/appendix/ if they really are digging information about licenses. I know you'd prefer all on one page but that's how it works for now. Re the headers linking to feature pages, those don't exist. A legend would probably be easiest now, but an eventual glossary (#238) could be another link target. I think much less of a problem since tooltips work in every cell now (#408). |
|
I'd love a link at the bottom of the main page for now: 'Compare licenses' - thanks for your incredible work, and don't feel discouraged by my criticism! |
|
@jhli that sounds like a request rather than criticism! I'm pretty disinclined to link from One of the great things about the web (well, the web of pages, sometimes lost with poorly designed single page apps!) is that if you think some page other than the home page is most useful to people you're communicating with, you can send them a link to that most useful page. As you thankfully don't need permission, I instead encourage you to send/link to http://choosealicense.com/appendix often. 😄 |
|
A table row for https://choosealicense.com/no-permission/ would help compare everything on one page |

This is quite ugly. Improvements or something better welcomed.
Closes #388 see there for motivation.
Additionally I wish I had made a table like this a long time ago, would have caught more license description errors earlier.