Skip to content

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Nov 21, 2024

This PR fixes lingering array index access that I missed when I converted getPullRequestEditedDiffRanges() results from tuples to DiffThunkRange objects.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

This commit fixes lingering array index access that I missed when I
converted getPullRequestEditedDiffRanges() results from tuples to
DiffThunkRange objects.
@cklin cklin force-pushed the cklin/DiffThunkRange-fix branch from 8914b01 to 2eea97e Compare November 21, 2024 21:49
@cklin cklin marked this pull request as ready for review November 21, 2024 22:05
@cklin cklin requested a review from a team as a code owner November 21, 2024 22:05
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! 🧹

@cklin cklin merged commit af49565 into main Dec 2, 2024
534 checks passed
@cklin cklin deleted the cklin/DiffThunkRange-fix branch December 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants