Skip to content

start-proxy: Skip proxy setup if no credentials are available #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

start-proxy: Skip proxy setup if no credentials are available #2724

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d7758b
Skip proxy if no credentials
marcogario Jan 24, 2025
8aa028b
Merge branch 'main' into marcogario/skip_proxy
marcogario Jan 27, 2025
76622e7
Merge branch 'main' into marcogario/skip_proxy
marcogario Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/start-proxy-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/start-proxy-action.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/start-proxy-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ async function runWrapper() {
actionsUtil.getOptionalInput("registries_credentials"),
actionsUtil.getOptionalInput("language"),
);

if (credentials.length === 0) {
logger.info("No credentials found, skipping proxy setup.");
return;
}

logger.info(
`Credentials loaded for the following registries:\n ${credentials
.map((c) => credentialToStr(c))
Expand Down
Loading