Skip to content

Ensure artifacts are only uploaded in safe situations #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Ensure artifacts are only uploaded in safe situations #2726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2bab9f7
Ensure artifacts are only uploaded in safe situations
aeisenberg Jan 25, 2025
5ff2464
Update changelog
aeisenberg Jan 25, 2025
f71067b
Stop using feature-flag support for determining if a feature is active
aeisenberg Jan 26, 2025
346d067
Fix CLI versions
aeisenberg Jan 27, 2025
a2c1b36
Iterate over each version
aeisenberg Jan 27, 2025
62c322f
Add better comments around artifact upload tests
aeisenberg Jan 27, 2025
a879704
Clarify test fail;ure message
aeisenberg Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...hub/workflows/debug-artifacts-failure.yml → ...orkflows/debug-artifacts-failure-safe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ on:
workflow_dispatch: {}
jobs:
upload-artifacts:
strategy:
fail-fast: false
matrix:
version:
- stable-v2.20.3
- default
- linked
- nightly-latest
Comment on lines +22 to +29
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now matrixing the build because we want to be sure it is working in the versions we know about.

name: Upload debug artifacts after failure in analyze
continue-on-error: true
env:
Expand All @@ -36,7 +44,7 @@ jobs:
id: prepare-test
uses: ./.github/actions/prepare-test
with:
version: linked
version: ${{ matrix.version }}
- uses: actions/setup-go@v5
with:
go-version: ^1.13.1
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/debug-artifacts.yml → .github/workflows/debug-artifacts-safe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,7 @@ jobs:
fail-fast: false
matrix:
version:
- stable-v2.15.5
- stable-v2.16.6
- stable-v2.17.6
- stable-v2.18.4
- stable-v2.19.4
- stable-v2.20.3
- default
- linked
- nightly-latest
Expand Down
10 changes: 9 additions & 1 deletion lib/analyze-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action-post.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 17 additions & 9 deletions lib/debug-artifacts.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading