Skip to content

Commit 046018f

Browse files
committed
Java: Add example of missing sink generation.
1 parent 6f79480 commit 046018f

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

java/ql/test/utils/modelgenerator/dataflow/CaptureSinkModels.ext.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@ extensions:
77
- [ "p", "Sinks", False, "sink", "(Object)", "", "Argument[0]", "test-sink", "manual" ]
88
- [ "p", "Sinks", False, "sink2", "(Object)", "", "Argument[0]", "test-sink2", "manual" ]
99
- [ "p", "Sinks", False, "manualSinkAlreadyDefined", "(Object)", "", "Argument[0]", "test-sink", "manual" ]
10+
- [ "p", "Sinks", False, "saveAndGet", "(Object)", "", "Argument[0]", "test-sink", "df-generated"]
11+
12+
- addsTo:
13+
pack: codeql/java-all
14+
extensible: sourceModel
15+
data:
16+
- [ "p", "Sinks", False, "saveAndGet", "(Object)", "", "ReturnValue", "test-source", "manual"]
1017

1118
- addsTo:
1219
pack: codeql/java-all

java/ql/test/utils/modelgenerator/dataflow/p/Sinks.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,14 @@ public void sink2(Object o) {}
2525
// neutral=p;Sinks;nosink;(Object);summary;df-generated
2626
public void nosink(Object o) {}
2727

28+
// Sink and Source defined in the extensible file next to the sink test.
29+
// MISSING SINK
30+
// neutral=p;Sinks;saveAndGet;(Object);summary;df-generated
31+
public Object saveAndGet(Object o) {
32+
sink(o);
33+
return null;
34+
}
35+
2836
// sink=p;Sinks;true;copyFileToDirectory;(Path,Path,CopyOption[]);;Argument[0];path-injection;df-generated
2937
// sink=p;Sinks;true;copyFileToDirectory;(Path,Path,CopyOption[]);;Argument[1];path-injection;df-generated
3038
// neutral=p;Sinks;copyFileToDirectory;(Path,Path,CopyOption[]);summary;df-generated

0 commit comments

Comments
 (0)