Update go/ql/src/Security/CWE-798/HardcodedCredentials.ql

atorralba · atorralba · commit 304998d50e4c · 2024-02-14T12:15:20.000+01:00
diff --git a/go/ql/src/Security/CWE-798/HardcodedCredentials.ql b/go/ql/src/Security/CWE-798/HardcodedCredentials.ql
@@ -47,7 +47,6 @@ predicate sensitiveAssignment(
 predicate hardcodedPrivateKey(DataFlow::Node node, SensitiveExpr::Classification type) {
   node.getStringValue()
       .regexpMatch("(?s)-+BEGIN\\b.*\\bPRIVATE KEY-+.+-+END\\b.*\\bPRIVATE KEY-+\n?") and
-  (node.asExpr() instanceof StringLit or node.asExpr() instanceof AddExpr) and
   type = SensitiveExpr::certificate()
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ predicate sensitiveAssignment(`
`47`	`47`	`predicate hardcodedPrivateKey(DataFlow::Node node, SensitiveExpr::Classification type) {`
`48`	`48`	`node.getStringValue()`
`49`	`49`	`.regexpMatch("(?s)-+BEGIN\\b.\\bPRIVATE KEY-+.+-+END\\b.\\bPRIVATE KEY-+\n?") and`
`50`		`- (node.asExpr() instanceof StringLit or node.asExpr() instanceof AddExpr) and`
`51`	`50`	`type = SensitiveExpr::certificate()`
`52`	`51`	`}`
`53`	`52`