C++: fix a join order in range analysis

rdmarsh2 · rdmarsh2 · commit 31b61b1aa630 · 2023-01-12T16:38:57.000-05:00
diff --git a/cpp/ql/lib/experimental/semmle/code/cpp/semantic/analysis/RangeAnalysisStage.qll b/cpp/ql/lib/experimental/semmle/code/cpp/semantic/analysis/RangeAnalysisStage.qll
@@ -268,7 +268,7 @@ module RangeStage<DeltaSig D, BoundSig<D> Bounds, LangSig<D> LangParam, UtilSig<
   private class SafeCastExpr extends ConvertOrBoxExpr {
     SafeCastExpr() {
       conversionCannotOverflow(getTrackedType(pragma[only_bind_into](getOperand())),
-        getTrackedType(this))
+      pragma[only_bind_out](getTrackedType(this)))
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ module RangeStage<DeltaSig D, BoundSig<D> Bounds, LangSig<D> LangParam, UtilSig<`
`268`	`268`	`private class SafeCastExpr extends ConvertOrBoxExpr {`
`269`	`269`	`SafeCastExpr() {`
`270`	`270`	`conversionCannotOverflow(getTrackedType(pragma[only_bind_into](getOperand())),`
`271`		`- getTrackedType(this))`
	`271`	`+ pragma[only_bind_out](getTrackedType(this)))`
`272`	`272`	`}`
`273`	`273`	`}`
`274`	`274`