Skip to content

Commit 61df4d2

Browse files
committed
Merge branch 'aegilops/polyfill-io-compromised-script' of https://github.com/aegilops/codeql into aegilops/polyfill-io-compromised-script
2 parents 00d91dc + 3f37fe6 commit 61df4d2

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

javascript/ql/src/Security/CWE-830/FunctionalityFromUntrustedDomain.qhelp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@
4848
</p>
4949

5050
<p>
51-
To help mitigate future risk of including a script that could be compromised, consider whether you need to
52-
use a polyfill or other library at all. Modern browsers do not require a polyfill, and other popular libraries are redundant after enhancements to HTML 5.
51+
To help mitigate the risk of including a script that could be compromised in the future, consider whether you need to
52+
use polyfill or another library at all. Modern browsers do not require a polyfill, and other popular libraries were made redundant by enhancements to HTML 5.
5353
</p>
5454

5555
<p>
56-
If you do need a polyfill service or library, move to using a trusted CDN.
56+
If you do need a polyfill service or library, move to using a CDN that you trust.
5757
</p>
5858

5959
<p>
@@ -63,7 +63,7 @@
6363

6464
A dynamic service cannot be easily used with SRI. Nevertheless,
6565
it is possible to list multiple acceptable SHA hashes in the <code>integrity</code> attribute,
66-
such as those for the content generated for major browers used by your users.
66+
such as hashes for the content required for the major browsers used by your users.
6767
</p>
6868

6969
<p>
@@ -85,7 +85,7 @@
8585
<sample src="polyfill-trusted.html" />
8686

8787
<p>
88-
If you can investigate the most used browsers by your users, you can list the hashes of the polyfills for those browsers:
88+
If you know which browsers are used by the majority of your users, you can list the hashes of the polyfills for those browsers:
8989
</p>
9090

9191
<sample src="polyfill-sri.html" />

javascript/ql/src/Security/CWE-830/FunctionalityFromUntrustedDomain.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @name Untrusted domain used in script or other content
3-
* @description Use of a script or other content from an untrusted or compromised domain
3+
* @description Using a resource from an untrusted or compromised domain makes your code vulnerable to receiving malicious code.
44
* @kind problem
55
* @security-severity 7.2
66
* @problem.severity error

0 commit comments

Comments
 (0)