Skip to content

Commit ab15a19

Browse files
committed
Address review comments
1 parent 166a368 commit ab15a19

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,9 @@ predicate clearsContent(Node n, Content c) {
192192
* Holds if the value that is being tracked is expected to be stored inside content `c`
193193
* at node `n`.
194194
*/
195-
predicate expectsContent(Node n, ContentSet c) { none() }
195+
predicate expectsContent(Node n, ContentSet c) {
196+
FlowSummaryImpl::Private::Steps::summaryExpectsContent(n, c)
197+
}
196198

197199
/** Gets the type of `n` used for type pruning. */
198200
DataFlowType getNodeType(Node n) {

go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImplSpecific.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ DataFlowType getCallbackReturnType(DataFlowType t, ReturnKind rk) { none() }
6161
* `input`, output specification `output`, kind `kind`, and a flag `generated`
6262
* stating whether the summary is autogenerated.
6363
*/
64-
predicate summaryElement(Callable c, string input, string output, string kind, boolean generated) {
64+
predicate summaryElement(
65+
SummarizedCallableBase c, string input, string output, string kind, boolean generated
66+
) {
6567
exists(
6668
string namespace, string type, boolean subtypes, string name, string signature, string ext
6769
|

0 commit comments

Comments
 (0)