C++: use in/out barriers with flow state #14331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asgerf Bit late to the party, but thanks! Changes to |
It is not clear that this does what we want here, and the query is severly broken in any case.
C++: Revert changes to `cpp/constant-array-overflow`
There was a problem hiding this comment.
Pull Request Overview
This PR updates the C++ command injection query to use flow state-aware barriers. The change modifies the isBarrierOut predicate to accept a FlowState parameter, allowing for more precise barrier logic that can differentiate between different flow states in the data flow analysis.
Key Changes
- Modified the
isBarrierOutpredicate signature to include aFlowStateparameter - Updated the barrier implementation to use state-aware sink checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this as part of testing this PR. Just thought I'd put it here in case you'd like it to be merged.