C++: Fix duplicate "final global value" nodes #15282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
reviewed
Jan 11, 2024
|
Sorry for the long answers @geoffw0. I figured I should give a fully explanatory answer to these questions as we're trying to spread out the knowledge a bit more on the team 😅 |
Yes, and likewise apologies for pushing for every detail for the same reason. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
geoffw0
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had hoped that this would fix the performance problems in #15194, but it doesn't look like it. Nevertheless, I think we should get this fix in since it may still be a (small) performance optimization and it fixes more pointer/pointee conflation of global variables.
I've verified that all the lost results are due to pointer/pointee conflation being removed from global variables 🎉