Rust: Improve rust/ctor-initialization #18176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
commented
Dec 2, 2024
|
|
||
| fn call_target3_1() { | ||
| _ = stderr().write_all(b"Hello, world!"); // $ MISSING: Alert=source3_1 Alert=source3_3 Alert=source3_4 | ||
| _ = stderr().write_all(b"Hello, world!"); // $ Alert=source3_1 Alert=source3_3 MISSING: Alert=source3_4 |
Contributor
Author
There was a problem hiding this comment.
The source3_4 result is still missing because the call to bad3_3() has no getStaticTarget().
hvitved
requested changes
Dec 2, 2024
paldepind
reviewed
Dec 2, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
requested changes
Dec 2, 2024
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
One last thing, otherwise LGTM. Also, remember to run DCA before merging.
hvitved
approved these changes
Dec 2, 2024
paldepind
approved these changes
Dec 3, 2024
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Looks great. Also very instructive for me to see how a query like this is made.
Contributor
Author
Me too to be honest. I've reviewed and edited, but I think never created from scratch a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the
rust/ctor-initializationquery, adding so-called "transitive" results through calls where the target is in the database.