Skip to content

C++: Fix more FPs with extraction errors on cpp/wrong-type-format-arguments #18200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calumgrant merged 5 commits into from
Dec 6, 2024
Merged

C++: Fix more FPs with extraction errors on cpp/wrong-type-format-arguments #18200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1942402
C++: Test for erroneous string types
calumgrant Dec 4, 2024
28c5187
C++: Remove FPs in cpp/wrong-type-format-argument when string type is…
calumgrant Dec 4, 2024
12b4c0a
C++: Change note
calumgrant Dec 5, 2024
2cd4e1a
C++: Use Expr.stripType()
calumgrant Dec 6, 2024
5aa604b
Update cpp/ql/src/change-notes/2024-12-05-wrong-type-format-args.md
calumgrant Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ where
) and
not arg.isAffectedByMacro() and
not arg.isFromUninstantiatedTemplate(_) and
not actual.getUnspecifiedType() instanceof ErroneousType and
not actual.stripType() instanceof ErroneousType and
not arg.(Call).mayBeFromImplicitlyDeclaredFunction()
select arg,
"This format specifier for type '" + expected.getName() + "' does not match the argument type '" +
Expand Down
4 changes: 4 additions & 0 deletions cpp/ql/src/change-notes/2024-12-05-wrong-type-format-args.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The "Wrong type of arguments to formatting function" query (`cpp/wrong-type-format-argument`) no longer produces results when an argument type has an extraction error.
3 changes: 2 additions & 1 deletion cpp/ql/test/query-tests/Likely Bugs/Format/WrongTypeFormatArguments/Buildless/tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
int printf(const char * format, ...);
int fprintf();

void f() {
void f(UNKNOWN_CHAR * str) {
printf("%s", 1); // BAD
printf("%s", implicit_function()); // GOOD - we should ignore the type
sprintf(0, "%s", ""); // GOOD
fprintf(0, "%s", ""); // GOOD
printf("%s", str); // GOOD - erroneous type is ignored
}