Rust: Add % of files extracted without errors to summary stats. #18236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
added
no-change-note-required
redsun82
approved these changes
Dec 6, 2024
Contributor
redsun82
left a comment
redsun82
left a comment
There was a problem hiding this comment.
Thank you so much for this!
I think the exist(file.getRelativePath()) makes a lot of sense and is more future-proof. The numbers I see in integration tests are exactly what I expected. The lower number in the test is probably due to us not running cargo check on the tests in the past, and some compilation errors are probably present there. We should fix that eventually, and turn cargo check on on all the tests but those that explicitly require failure, but not in the context of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add % of files extracted without errors to summary stats. Requested by @redsun82 .
exists(f.getRelativePath())part makes any difference right now, but let me know if you have a preference about it.openvmmI get 91%.int, because I'm not confident I can output a float or string and pick it up in DCA. Again, if this is a problem please say and I'll look into what I can do.