Rust: Add more cases to inferCertainType
#20291
Merged
+14
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/type-inference-more-certain-types
branch
from
4358177 to
6453b71
Compare
hvitved
requested review from
Copilot and
paldepind
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR refactors type inference logic by moving several type inference methods from the general inference module to the more precise "certain type inference" module. This change improves the accuracy of type inference by handling cases where the type can be determined with certainty.
- Move reference, tuple, async block, array, and cast type inference from general to certain type inference
- Remove duplicate inference rules that were already present in both modules
- Update expected test results to reflect improved precision
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/internal/TypeInference.qll | Moves type inference methods to CertainTypeInference module and removes duplicates from general inference |
| rust/ql/test/library-tests/type-inference/type-inference.expected | Updates expected test results reflecting improved type inference precision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20179 follow-up.
DCA looks OK.