Skip to content

JS: Remove totalorder() #20323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
+0 −58
Merged

JS: Remove totalorder() #20323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,12 +408,6 @@ class DataFlowCallable extends TDataFlowCallable {

/** Gets the corresponding `LibraryCallable` if this is a library callable. */
LibraryCallable asLibraryCallable() { this = MkLibraryCallable(result) }

int totalorder() {
result = TotalOrdering::astNodeId(this.asSourceCallable()).bitShiftLeft(1)
or
result = TotalOrdering::libraryCallableId(this.asLibraryCallable()).bitShiftLeft(1) + 1
}
}

/** A callable defined in library code, identified by a unique string. */
Expand Down Expand Up @@ -797,47 +791,6 @@ private newtype TDataFlowCall =
FlowSummaryImpl::Private::summaryCallbackRange(c, receiver)
}

private module TotalOrdering {
private predicate astNodeRefl(AstNode x, AstNode y) { x = y }

int astNodeId(AstNode n) = equivalenceRelation(astNodeRefl/2)(n, result)

predicate dataFlowNodeId(DataFlow::Node node, int cls, int content) {
exists(AstNode n |
node = TValueNode(n) and cls = 1 and content = astNodeId(n)
or
node = TReflectiveCallNode(n, _) and cls = 2 and content = astNodeId(n)
)
}

predicate callId(DataFlowCall call, int cls, int child, int extra) {
exists(DataFlow::Node node |
call = MkOrdinaryCall(node) and dataFlowNodeId(node, cls - 1000, child) and extra = 0
or
call = MkPartialCall(node, _) and dataFlowNodeId(node, cls - 2000, child) and extra = 0
or
call = MkBoundCall(node, extra) and dataFlowNodeId(node, cls - 3000, child)
or
call = MkAccessorCall(node) and dataFlowNodeId(node, cls - 4000, child) and extra = 0
)
or
exists(Function f |
call = MkImpliedLambdaCall(f) and cls = 5000 and child = astNodeId(f) and extra = 0
)
or
exists(
FlowSummaryImpl::Public::SummarizedCallable c, FlowSummaryImpl::Private::SummaryNode receiver
|
call = MkSummaryCall(c, receiver) and
cls = 6000 and
c = rank[child](FlowSummaryImpl::Public::SummarizedCallable cs) and
extra = 0
)
}

int libraryCallableId(LibraryCallable callable) { callable = rank[result](LibraryCallable c) }
}

class DataFlowCall extends TDataFlowCall {
DataFlowCallable getEnclosingCallable() { none() } // Overridden in subclass

Expand All @@ -861,15 +814,6 @@ class DataFlowCall extends TDataFlowCall {
}

Location getLocation() { none() } // Overridden in subclass

int totalorder() {
this =
rank[result](DataFlowCall call, int x, int y, int z |
TotalOrdering::callId(call, x, y, z)
|
call order by x, y, z
)
}
}

private class OrdinaryCall extends DataFlowCall, MkOrdinaryCall {
Expand Down Expand Up @@ -1653,8 +1597,6 @@ abstract class NodeRegion extends Unit {

/** Holds if this region contains `n`. */
predicate contains(Node n) { none() }

int totalOrder() { none() }
}

/**
Expand Down