Skip to content

Shared and Sync: Fix some Ql4Ql violations. #20335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Shared and Sync: Fix some Ql4Ql violations. #20335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

/**
* Holds if the value at `(type, path)` should be seen as a flow
* source of the given `kind`.
* source of the given `kind` and `madId` is the data extension row number.
*
* The kind `remote` represents a general remote flow source.
*/
Expand All @@ -14,13 +14,14 @@ extensible predicate sourceModel(

/**
* Holds if the value at `(type, path)` should be seen as a sink
* of the given `kind`.
* of the given `kind` and `madId` is the data extension row number.
*/
extensible predicate sinkModel(string type, string path, string kind, QlBuiltins::ExtensionId madId);

/**
* Holds if in calls to `(type, path)`, the value referred to by `input`
* can flow to the value referred to by `output`.
* can flow to the value referred to by `output` and `madId` is the data
* extension row number.
*
* `kind` should be either `value` or `taint`, for value-preserving or taint-preserving steps,
* respectively.
Expand Down
7 changes: 4 additions & 3 deletions python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModelsExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

/**
* Holds if the value at `(type, path)` should be seen as a flow
* source of the given `kind`.
* source of the given `kind` and `madId` is the data extension row number.
*
* The kind `remote` represents a general remote flow source.
*/
Expand All @@ -14,13 +14,14 @@ extensible predicate sourceModel(

/**
* Holds if the value at `(type, path)` should be seen as a sink
* of the given `kind`.
* of the given `kind` and `madId` is the data extension row number.
*/
extensible predicate sinkModel(string type, string path, string kind, QlBuiltins::ExtensionId madId);

/**
* Holds if in calls to `(type, path)`, the value referred to by `input`
* can flow to the value referred to by `output`.
* can flow to the value referred to by `output` and `madId` is the data
* extension row number.
*
* `kind` should be either `value` or `taint`, for value-preserving or taint-preserving steps,
* respectively.
Expand Down
7 changes: 4 additions & 3 deletions ruby/ql/lib/codeql/ruby/frameworks/data/internal/ApiGraphModelsExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

/**
* Holds if the value at `(type, path)` should be seen as a flow
* source of the given `kind`.
* source of the given `kind` and `madId` is the data extension row number.
*
* The kind `remote` represents a general remote flow source.
*/
Expand All @@ -14,13 +14,14 @@ extensible predicate sourceModel(

/**
* Holds if the value at `(type, path)` should be seen as a sink
* of the given `kind`.
* of the given `kind` and `madId` is the data extension row number.
*/
extensible predicate sinkModel(string type, string path, string kind, QlBuiltins::ExtensionId madId);

/**
* Holds if in calls to `(type, path)`, the value referred to by `input`
* can flow to the value referred to by `output`.
* can flow to the value referred to by `output` and `madId` is the data
* extension row number.
*
* `kind` should be either `value` or `taint`, for value-preserving or taint-preserving steps,
* respectively.
Expand Down
6 changes: 2 additions & 4 deletions shared/quantum/codeql/quantum/experimental/Model.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ module CryptographyBase<LocationSig Location, InputSig<Location> Input> {
*/
abstract class ArtifactConsumer extends ConsumerElement {
/**
* Use `getAKnownArtifactSource() instead. The behaviour of these two predicates is equivalent.
* Use `getAKnownArtifactSource() instead. The behavior of these two predicates is equivalent.
Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good correction of 'behaviour' to 'behavior' for American English consistency.

Copilot uses AI. Check for mistakes.

*/
final override KnownElement getAKnownSource() { result = this.getAKnownArtifactSource() }

Expand Down Expand Up @@ -1841,9 +1841,7 @@ module CryptographyBase<LocationSig Location, InputSig<Location> Input> {
* An SCRYPT key derivation algorithm node.
*/
class ScryptAlgorithmNode extends KeyDerivationAlgorithmNode {
ScryptAlgorithmInstance scryptInstance;

ScryptAlgorithmNode() { scryptInstance = instance.asAlg() }
ScryptAlgorithmNode() { instance.asAlg() instanceof ScryptAlgorithmInstance }

/**
* Gets the iteration count (`N`) argument
Expand Down
Loading