-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java: Add MaDs for java.lang.ScopedValue
#20339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IdrissRio
wants to merge
6
commits into
main
Choose a base branch
from
idrissrio/scoped-values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+168
−162
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a34b362
Java: accept new test results after extractor update
IdrissRio 5290f86
Java: Add failing test for Scoped Values
IdrissRio d25641b
Java: Add MaDs for `java.lang.scoped`
IdrissRio 9bc14e0
Java: accept new test results
IdrissRio 2c076f6
Java: Add new change note
IdrissRio 3320fa0
Java: Fix missing right brace in test comment
IdrissRio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
extensions: | ||
- addsTo: | ||
pack: codeql/java-all | ||
extensible: summaryModel | ||
data: | ||
- ["java.lang", "ScopedValue", False, "where", "(ScopedValue,Object)", "", "Argument[1]", "Argument[0].SyntheticField[java.lang.ScopedValue.boundValue]", "value", "manual"] | ||
- ["java.lang", "ScopedValue", True, "get", "()", "", "Argument[this].SyntheticField[java.lang.ScopedValue.boundValue]", "ReturnValue", "value", "manual"] | ||
- ["java.lang", "ScopedValue", False, "where", "(ScopedValue,Object)", "", "Argument[0]", "ReturnValue", "taint", "manual"] | ||
- ["java.lang", "ScopedValue$Carrier", False, "where", "(ScopedValue,Object)", "", "Argument[1]", "Argument[0].SyntheticField[java.lang.ScopedValue.boundValue]", "value", "manual"] | ||
- ["java.lang", "ScopedValue$Carrier", False, "where", "(ScopedValue,Object)", "", "Argument[0]", "ReturnValue", "taint", "manual"] | ||
|
||
- addsTo: | ||
pack: codeql/java-all | ||
extensible: neutralModel | ||
data: | ||
- ["java.lang", "ScopedValue", "newInstance", "()", "summary", "manual"] | ||
- ["java.lang", "ScopedValue", "isBound", "()", "summary", "manual"] | ||
- ["java.lang", "ScopedValue$Carrier", "run", "(Runnable)", "summary", "manual"] | ||
- ["java.lang", "ScopedValue$Carrier", "call", "(Callable)", "summary", "manual"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,30 +16,6 @@ methodWithDuplicate | |
| AbstractCollection<E> | removeAll | Collection<?> | | ||
| AbstractCollection<E> | retainAll | Collection<?> | | ||
| AbstractCollection<E> | toArray | T[] | | ||
| AbstractCollection<Entry<K,V>> | add | Entry<K,V> | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
| AbstractCollection<Entry<K,V>> | addAll | Collection<? extends Entry<K,V>> | | ||
| AbstractCollection<Entry<K,V>> | contains | Object | | ||
| AbstractCollection<Entry<K,V>> | containsAll | Collection<?> | | ||
| AbstractCollection<Entry<K,V>> | remove | Object | | ||
| AbstractCollection<Entry<K,V>> | removeAll | Collection<?> | | ||
| AbstractCollection<Entry<K,V>> | retainAll | Collection<?> | | ||
| AbstractCollection<Entry<K,V>> | toArray | T[] | | ||
| AbstractCollection<K> | add | K | | ||
| AbstractCollection<K> | addAll | Collection<? extends K> | | ||
| AbstractCollection<K> | contains | Object | | ||
| AbstractCollection<K> | containsAll | Collection<?> | | ||
| AbstractCollection<K> | remove | Object | | ||
| AbstractCollection<K> | removeAll | Collection<?> | | ||
| AbstractCollection<K> | retainAll | Collection<?> | | ||
| AbstractCollection<K> | toArray | T[] | | ||
| AbstractCollection<Runnable> | add | Runnable | | ||
| AbstractCollection<Runnable> | addAll | Collection<? extends Runnable> | | ||
| AbstractCollection<Runnable> | contains | Object | | ||
| AbstractCollection<Runnable> | containsAll | Collection<?> | | ||
| AbstractCollection<Runnable> | remove | Object | | ||
| AbstractCollection<Runnable> | removeAll | Collection<?> | | ||
| AbstractCollection<Runnable> | retainAll | Collection<?> | | ||
| AbstractCollection<Runnable> | toArray | T[] | | ||
| AbstractCollection<String> | add | String | | ||
| AbstractCollection<String> | addAll | Collection<? extends String> | | ||
| AbstractCollection<String> | contains | Object | | ||
|
@@ -56,14 +32,6 @@ methodWithDuplicate | |
| AbstractCollection<T> | removeAll | Collection<?> | | ||
| AbstractCollection<T> | retainAll | Collection<?> | | ||
| AbstractCollection<T> | toArray | T[] | | ||
| AbstractCollection<V> | add | V | | ||
| AbstractCollection<V> | addAll | Collection<? extends V> | | ||
| AbstractCollection<V> | contains | Object | | ||
| AbstractCollection<V> | containsAll | Collection<?> | | ||
| AbstractCollection<V> | remove | Object | | ||
| AbstractCollection<V> | removeAll | Collection<?> | | ||
| AbstractCollection<V> | retainAll | Collection<?> | | ||
| AbstractCollection<V> | toArray | T[] | | ||
| AbstractList | add | E | | ||
| AbstractList | add | int | | ||
| AbstractList | addAll | Collection<? extends E> | | ||
|
@@ -103,14 +71,14 @@ methodWithDuplicate | |
| AbstractMap | put | V | | ||
| AbstractMap | putAll | Map<? extends K,? extends V> | | ||
| AbstractMap | remove | Object | | ||
| AbstractMap<Identity,Entry<?>> | containsKey | Object | | ||
| AbstractMap<Identity,Entry<?>> | containsValue | Object | | ||
| AbstractMap<Identity,Entry<?>> | equals | Object | | ||
| AbstractMap<Identity,Entry<?>> | get | Object | | ||
| AbstractMap<Identity,Entry<?>> | put | Entry<?> | | ||
| AbstractMap<Identity,Entry<?>> | put | Identity | | ||
| AbstractMap<Identity,Entry<?>> | putAll | Map<? extends Identity,? extends Entry<?>> | | ||
| AbstractMap<Identity,Entry<?>> | remove | Object | | ||
| AbstractMap<Identity,Object> | containsKey | Object | | ||
| AbstractMap<Identity,Object> | containsValue | Object | | ||
| AbstractMap<Identity,Object> | equals | Object | | ||
| AbstractMap<Identity,Object> | get | Object | | ||
| AbstractMap<Identity,Object> | put | Identity | | ||
| AbstractMap<Identity,Object> | put | Object | | ||
| AbstractMap<Identity,Object> | putAll | Map<? extends Identity,? extends Object> | | ||
| AbstractMap<Identity,Object> | remove | Object | | ||
| AbstractMap<K,V> | containsKey | Object | | ||
| AbstractMap<K,V> | containsValue | Object | | ||
| AbstractMap<K,V> | equals | Object | | ||
|
@@ -179,17 +147,6 @@ methodWithDuplicate | |
| Collection<K> | retainAll | Collection<?> | | ||
| Collection<K> | toArray | IntFunction<T[]> | | ||
| Collection<K> | toArray | T[] | | ||
| Collection<Runnable> | add | Runnable | | ||
| Collection<Runnable> | addAll | Collection<? extends Runnable> | | ||
| Collection<Runnable> | contains | Object | | ||
| Collection<Runnable> | containsAll | Collection<?> | | ||
| Collection<Runnable> | equals | Object | | ||
| Collection<Runnable> | remove | Object | | ||
| Collection<Runnable> | removeAll | Collection<?> | | ||
| Collection<Runnable> | removeIf | Predicate<? super Runnable> | | ||
| Collection<Runnable> | retainAll | Collection<?> | | ||
| Collection<Runnable> | toArray | IntFunction<T[]> | | ||
| Collection<Runnable> | toArray | T[] | | ||
| Collection<String> | add | String | | ||
| Collection<String> | addAll | Collection<? extends String> | | ||
| Collection<String> | contains | Object | | ||
|
@@ -332,37 +289,36 @@ methodWithDuplicate | |
| Map | replace | K | | ||
| Map | replace | V | | ||
| Map | replaceAll | BiFunction<? super K,? super V,? extends V> | | ||
| Map<Identity,Entry<?>> | compute | BiFunction<? super Identity,? super Entry<?>,? extends Entry<?>> | | ||
| Map<Identity,Entry<?>> | compute | Identity | | ||
| Map<Identity,Entry<?>> | computeIfAbsent | Function<? super Identity,? extends Entry<?>> | | ||
| Map<Identity,Entry<?>> | computeIfAbsent | Identity | | ||
| Map<Identity,Entry<?>> | computeIfPresent | BiFunction<? super Identity,? super Entry<?>,? extends Entry<?>> | | ||
| Map<Identity,Entry<?>> | computeIfPresent | Identity | | ||
| Map<Identity,Entry<?>> | containsKey | Object | | ||
| Map<Identity,Entry<?>> | containsValue | Object | | ||
| Map<Identity,Entry<?>> | copyOf | Map<? extends K,? extends V> | | ||
| Map<Identity,Entry<?>> | entry | K | | ||
| Map<Identity,Entry<?>> | entry | V | | ||
| Map<Identity,Entry<?>> | equals | Object | | ||
| Map<Identity,Entry<?>> | forEach | BiConsumer<? super Identity,? super Entry<?>> | | ||
| Map<Identity,Entry<?>> | get | Object | | ||
| Map<Identity,Entry<?>> | getOrDefault | Entry<?> | | ||
| Map<Identity,Entry<?>> | getOrDefault | Object | | ||
| Map<Identity,Entry<?>> | merge | BiFunction<? super Entry<?>,? super Entry<?>,? extends Entry<?>> | | ||
| Map<Identity,Entry<?>> | merge | Entry<?> | | ||
| Map<Identity,Entry<?>> | merge | Identity | | ||
| Map<Identity,Entry<?>> | of | K | | ||
| Map<Identity,Entry<?>> | of | V | | ||
| Map<Identity,Entry<?>> | ofEntries | Entry<? extends K,? extends V>[] | | ||
| Map<Identity,Entry<?>> | put | Entry<?> | | ||
| Map<Identity,Entry<?>> | put | Identity | | ||
| Map<Identity,Entry<?>> | putAll | Map<? extends Identity,? extends Entry<?>> | | ||
| Map<Identity,Entry<?>> | putIfAbsent | Entry<?> | | ||
| Map<Identity,Entry<?>> | putIfAbsent | Identity | | ||
| Map<Identity,Entry<?>> | remove | Object | | ||
| Map<Identity,Entry<?>> | replace | Entry<?> | | ||
| Map<Identity,Entry<?>> | replace | Identity | | ||
| Map<Identity,Entry<?>> | replaceAll | BiFunction<? super Identity,? super Entry<?>,? extends Entry<?>> | | ||
| Map<Identity,Object> | compute | BiFunction<? super Identity,? super Object,? extends Object> | | ||
| Map<Identity,Object> | compute | Identity | | ||
| Map<Identity,Object> | computeIfAbsent | Function<? super Identity,? extends Object> | | ||
| Map<Identity,Object> | computeIfAbsent | Identity | | ||
| Map<Identity,Object> | computeIfPresent | BiFunction<? super Identity,? super Object,? extends Object> | | ||
| Map<Identity,Object> | computeIfPresent | Identity | | ||
| Map<Identity,Object> | containsKey | Object | | ||
| Map<Identity,Object> | containsValue | Object | | ||
| Map<Identity,Object> | copyOf | Map<? extends K,? extends V> | | ||
| Map<Identity,Object> | entry | K | | ||
| Map<Identity,Object> | entry | V | | ||
| Map<Identity,Object> | equals | Object | | ||
| Map<Identity,Object> | forEach | BiConsumer<? super Identity,? super Object> | | ||
| Map<Identity,Object> | get | Object | | ||
| Map<Identity,Object> | getOrDefault | Object | | ||
| Map<Identity,Object> | merge | BiFunction<? super Object,? super Object,? extends Object> | | ||
| Map<Identity,Object> | merge | Identity | | ||
| Map<Identity,Object> | merge | Object | | ||
| Map<Identity,Object> | of | K | | ||
| Map<Identity,Object> | of | V | | ||
| Map<Identity,Object> | ofEntries | Entry<? extends K,? extends V>[] | | ||
| Map<Identity,Object> | put | Identity | | ||
| Map<Identity,Object> | put | Object | | ||
| Map<Identity,Object> | putAll | Map<? extends Identity,? extends Object> | | ||
| Map<Identity,Object> | putIfAbsent | Identity | | ||
| Map<Identity,Object> | putIfAbsent | Object | | ||
| Map<Identity,Object> | remove | Object | | ||
| Map<Identity,Object> | replace | Identity | | ||
| Map<Identity,Object> | replace | Object | | ||
| Map<Identity,Object> | replaceAll | BiFunction<? super Identity,? super Object,? extends Object> | | ||
| Map<K,V> | compute | BiFunction<? super K,? super V,? extends V> | | ||
| Map<K,V> | compute | K | | ||
| Map<K,V> | computeIfAbsent | Function<? super K,? extends V> | | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC it might be problematic to add these as neutrals. They do likely run their callbacks and thus could be part of a flow path.