Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Oct 10, 2025

The second gomod configuration we had in dependabot.yml was intended to exclude all test dependencies, but never really worked because the Dependabot PRs we got for them were security updates that have to be disabled in the repository settings for the test directories instead.

We are still occasionally seeing nuisance PRs from Dependabot for dependencies of test projects, so this PR changes the Dependabot configuration in the repo to use the exclude-paths to see if that helps. If not, we'll likely need to make some more adjustments in the repo settings.

@mbg mbg requested a review from owen-mc October 10, 2025 11:49
@mbg mbg requested a review from a team as a code owner October 10, 2025 11:49
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 11:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

- dependency-name: "golang.org/x/mod"
- dependency-name: "golang.org/x/tools"
exclude-paths:
- "go/ql/**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading the documentation right, this path is relative to what we defined for "directory" above. So I'm not sure this will work.

Patterns are relative to the directory specified for the update configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I didn't spot that in the docs. In that case, this will not work at all and we'll have to update the configurations in the repo settings.

@mbg mbg closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants