JS: Avoid magic and improve a join in type resolution #20647
+47
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves performance in type resolution by adding pragma[nomagic] annotations and refactoring a complex join operation into more efficient helper predicates.
- Adds
pragma[nomagic]annotations to prevent expensive magic reorderings in various predicates - Refactors the complex join in
valueHasTypepredicate by extracting helper predicatesgetAReadContentRestricted,valueReadStepOnContent, andtypeMemberHostRead - Adds a
cachedannotation to the mainvalueHasTypepredicate
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TypeResolution.qll | Main performance improvements including pragma annotations and join optimization through extracted helper predicates |
| NameResolution.qll | Additional pragma[nomagic] annotations for consistency and performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor perf issue in type resolution