Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Mar 12, 2025

The CI workflow was no longer functional and contained a number of issues, which this PR addresses:

  • Adds explicit permissions, so that the workflow does not have the overly permissive legacy permissions
  • Updates the versions of the actions used
  • Newer versions of setup-go implement dependency caching themselves, so we don't have to do this ourselves
  • The workflow triggers meant that the workflow ran twice for PRs. The changes there should mean that the workflow only triggers for the pull_request event on PRs.

@mbg mbg self-assigned this Mar 12, 2025
Copilot AI review requested due to automatic review settings March 12, 2025 14:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A concise update to the CI workflow configuration to add explicit repository content permissions.

  • Adds explicit explicit permissions for the workflow by specifying repository contents have read access.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@mbg mbg requested a review from a team March 12, 2025 14:32
Copy link

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest note in the title/description that you also upgrade actions and remove explicit cache ops presumably due to replacement by setup-go. Otherwise lgtm.

@mbg mbg changed the title Add explicit permissions to workflow Add explicit permissions to workflow and update action versions Mar 12, 2025
@mbg mbg merged commit 9b61b6f into main Mar 12, 2025
5 checks passed
@mbg mbg deleted the mbg/fix/workflow-permissions branch March 17, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants