Skip to content

Conversation

@docs-bot
Copy link
Collaborator

This is an automated pull request to sync changes between the public and private repos.
Our bot will merge this pull request automatically.
To preserve continuity across repos, do not squash this pull request.

Copilot AI review requested due to automatic review settings July 14, 2025 21:33
@github github locked as spam and limited conversation to collaborators Jul 14, 2025
@docs-bot docs-bot merged commit 2758eba into main Jul 14, 2025
1 check passed
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is an automated pull request to sync changes between the public and private repos. The PR contains multiple updates to API documentation data files, including updated descriptions, new fields, and configuration updates.

  • Updates to GitHub Advanced Security descriptions across multiple API schema files
  • Addition of new fields for organization membership and release immutability
  • Updates to secret scanning patterns and search component improvements

Reviewed Changes

Copilot reviewed 60 out of 66 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/webhooks/lib/config.json Updates SHA reference for webhook configuration
src/webhooks/data/ghes-*/schema.json Adds descriptions for Advanced Security parameters and new membership/release fields
src/types.ts Adds new properties to Permalink and Page types
src/secret-scanning/lib/config.json Updates SHA references for secret scanning configuration
src/secret-scanning/data/public-docs.yml Adds new Val Town API token pattern and enables push protection for WebDriver API key
src/search/components/input/*.tsx React component updates for search functionality with key prop fixes
src/rest/lib/config.json Updates SHA reference for REST API configuration
src/rest/data/ghes-*/schema.json Adds Advanced Security descriptions and new API fields across multiple versions

.filter((item) => item.trim() !== '')
.map((item) => <>{item.trim()}</>)
placeHolderElements[1] = <CopilotIcon aria-hidden className="mr-1 ml-1" />
.map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>)
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using array index as part of the React key can cause issues if the array order changes. Consider using a more stable identifier or just the trimmed content if it's unique.

Suggested change
.map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>)
.map((item) => <span key={item.trim()}>{item.trim()}</span>)

Copilot uses AI. Check for mistakes.
Comment on lines +52 to +53
.map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>)
placeHolderElements[1] = <CopilotIcon key="copilot-icon" aria-hidden className="mr-1 ml-1" />
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct array index assignment after mapping can be fragile. The assumption that index 1 exists and should be the icon might not hold if the placeholder text structure changes.

Suggested change
.map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>)
placeHolderElements[1] = <CopilotIcon key="copilot-icon" aria-hidden className="mr-1 ml-1" />
.map((item, index) =>
item.trim() === '{{icon}}'
? <CopilotIcon key="copilot-icon" aria-hidden className="mr-1 ml-1" />
: <span key={`${item.trim()}-${index}`}>{item.trim()}</span>
)

Copilot uses AI. Check for mistakes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants