Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/headless-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ jobs:
- name: Run Playwright tests
env:
PLAYWRIGHT_WORKERS: ${{ fromJSON('[1, 4]')[github.repository == 'github/docs-internal'] }}
# workaround for https://github.com/nodejs/node/issues/59364 as of 22.18.0
NODE_OPTIONS: '--no-experimental-strip-types'

# Run playwright rendering tests and a11y tests (axe scans) as distinct checks
# so that we can run them without blocking merges until we can be confident
# results for a11y tests are meaningul and scenarios we're testing are correct.
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/local-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ jobs:
# by default failures are marked as "flaky" instead of "failed".
PLAYWRIGHT_RETRIES: 0
TEST_EARLY_ACCESS: ${{ github.repository == 'github/docs-internal' }}
# workaround for https://github.com/nodejs/node/issues/59364 as of 22.18.0
NODE_OPTIONS: '--no-experimental-strip-types'
run: npm run playwright-test -- playwright-local-dev

- name: Start server in the background
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ FROM ghcr.io/github/gh-base-image/gh-base-noble:20250805-204228-g50c20871f AS ba
# Must run as root
RUN apt-get -qq update && apt-get -qq install --no-install-recommends curl git \
&& curl -sL https://deb.nodesource.com/setup_22.x | bash - \
&& apt-get install -y nodejs=22.17.0-1nodesource1 \
&& apt-get install -y nodejs \
&& node --version

# Create the node user and home directory
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ With {% data variables.product.prodname_ghe_cloud %} and starting from {% data v

When creating an organization role, enterprise owners can use the same organization and repository permissions and base roles as organization owners—there is no difference in how these roles function or what they can allow.

{% data reusables.enterprise-accounts.access-enterprise %} {% data reusables.enterprise-accounts.people-tab %}
{% data reusables.enterprise-accounts.access-enterprise %}
{% data reusables.enterprise-accounts.people-tab %}
1. Select the "Organization Roles" section in the left-hand menu.
1. Create a new role using the "Create custom role" button, or edit an existing role using the ellipsis menu (...).

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@
"esm": "^3.2.25"
},
"engines": {
"node": "^20 || >=22.0.0 <22.18.0"
"node": "^20 || ^22"
},
"cacheDirectories": [
"node_modules",
Expand Down
1 change: 1 addition & 0 deletions src/frame/middleware/app-router-gateway.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export default function appRouterGateway(req: ExtendedRequest, res: Response, ne

if (
path.startsWith('/_next/') ||
path.startsWith('/_build') ||
path.startsWith('/assets/') ||
path.startsWith('/public/') ||
path.startsWith('/api/') ||
Expand Down
Loading