Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ If members of your enterprise access {% data variables.location.product_location
* Interactions with a resource owned by the personal account, including a repository, gist, or project
* Interactions with a public repository owned by an organization in your enterprise

{% data variables.product.github %} does not display IP address in the audit log for `api.request` events triggered by GraphQL requests.
{% data variables.product.github %} does not display IP addresses in the audit log for `api.request` events that do not have repository context, such as requests triggered by GraphQL or requests to endpoints that reference only a user or organization.

## Enabling display of IP addresses in the audit log

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ After you enable the feature, you can access the audit log to view events that i

{% data variables.product.github %} displays an IP address for each event in the organization audit log that meets these criteria.

* The actor is an organization member or owner
* The actor is an organization member or owner.
* The target is either an organization-owned repository that is private or internal, or an organization resource that is not a repository, such as a project.
* For `api.request` events, the request was not triggered by GraphQL.
* For `api.request` events, the request must have repository context; requests triggered by GraphQL or to endpoints that reference only a user or organization do not meet this condition.

## Enabling display of IP addresses in the audit log

Expand Down
4 changes: 2 additions & 2 deletions src/fixtures/fixtures/content/get-started/carousel/index.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
title: Carousel Test Category
title: Landing Page Carousel
intro: 'A test category page for testing the LandingCarousel component.'
versions:
fpt: '*'
ghes: '*'
ghec: '*'
layout: category-landing
layout: discovery-landing
recommended:
- /category-one/article-one
- /category-one/article-two
Expand Down
1 change: 1 addition & 0 deletions src/fixtures/fixtures/content/get-started/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ children:
- /versioning
- /learning-about-github
- /empty-categories
- /test-journey
- /carousel
- /article-grid-discovery
- /article-grid-bespoke
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
title: Test Journey Landing
title: Journey Landing
intro: 'Test page for journey tracks functionality'
layout: journey-landing
versions:
Expand Down
1 change: 0 additions & 1 deletion src/fixtures/fixtures/content/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ children:
# as if the URL had been `/en/free-pro-team@latest/get-started/anything`.
- search
- get-started
- test-journey
- early-access
- pages
- code-security
Expand Down
16 changes: 8 additions & 8 deletions src/fixtures/tests/playwright-rendering.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,7 @@ test('open search, Ask AI returns 400 error and shows general search results', a

test.describe('LandingCarousel component', () => {
test('displays carousel on test page', async ({ page }) => {
await page.goto('/get-started/carousel?feature=discovery-landing')
await page.goto('/get-started/carousel')

const carousel = page.locator('[data-testid="landing-carousel"]')
await expect(carousel).toBeVisible()
Expand All @@ -1026,7 +1026,7 @@ test.describe('LandingCarousel component', () => {

test('navigation works on desktop', async ({ page }) => {
await page.setViewportSize({ width: 1200, height: 800 })
await page.goto('/get-started/carousel?feature=discovery-landing')
await page.goto('/get-started/carousel')

const carousel = page.locator('[data-testid="landing-carousel"]')
await expect(carousel).toBeVisible()
Expand All @@ -1046,7 +1046,7 @@ test.describe('LandingCarousel component', () => {

test('responsive behavior on mobile', async ({ page }) => {
await page.setViewportSize({ width: 375, height: 667 })
await page.goto('/get-started/carousel?feature=discovery-landing')
await page.goto('/get-started/carousel')

const carousel = page.locator('[data-testid="landing-carousel"]')
await expect(carousel).toBeVisible()
Expand All @@ -1059,7 +1059,7 @@ test.describe('LandingCarousel component', () => {

test.describe('Journey Tracks', () => {
test('displays journey tracks on landing pages', async ({ page }) => {
await page.goto('/get-started?feature=journey-landing')
await page.goto('/get-started/test-journey')

const journeyTracks = page.locator('[data-testid="journey-tracks"]')
await expect(journeyTracks).toBeVisible()
Expand All @@ -1075,7 +1075,7 @@ test.describe('Journey Tracks', () => {
})

test('track expansion and collapse functionality', async ({ page }) => {
await page.goto('/get-started?feature=journey-landing')
await page.goto('/get-started/test-journey')

const firstTrack = page.locator('[data-testid="journey-track"]').first()
const expandButton = firstTrack.locator('summary')
Expand All @@ -1095,7 +1095,7 @@ test.describe('Journey Tracks', () => {
})

test('article navigation within tracks', async ({ page }) => {
await page.goto('/get-started?feature=journey-landing')
await page.goto('/get-started/test-journey')

const firstTrack = page.locator('[data-testid="journey-track"]').first()
const expandButton = firstTrack.locator('summary')
Expand All @@ -1112,7 +1112,7 @@ test.describe('Journey Tracks', () => {
})

test('preserves version in journey track links', async ({ page }) => {
await page.goto('/enterprise-cloud@latest/get-started?feature=journey-landing')
await page.goto('/enterprise-cloud@latest/get-started/test-journey')

const firstTrack = page.locator('[data-testid="journey-track"]').first()
const expandButton = firstTrack.locator('summary')
Expand All @@ -1127,7 +1127,7 @@ test.describe('Journey Tracks', () => {
})

test('handles liquid template rendering in track content', async ({ page }) => {
await page.goto('/get-started?feature=journey-landing')
await page.goto('/get-started/test-journey')

const tracks = page.locator('[data-testid="journey-track"]')

Expand Down
Loading