Update probot #164
Merged
Update probot #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [probot](https://github.com/probot/probot) from 12.3.3 to 13.4.3. - [Release notes](https://github.com/probot/probot/releases) - [Commits](probot/probot@v12.3.3...v13.4.3) --- updated-dependencies: - dependency-name: probot dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@probot/adapter-aws-lambda-serverless](https://github.com/probot/adapter-aws-lambda-serverless) from 3.0.4 to 4.0.2. - [Release notes](https://github.com/probot/adapter-aws-lambda-serverless/releases) - [Commits](probot/adapter-aws-lambda-serverless@v3.0.4...v4.0.2) --- updated-dependencies: - dependency-name: "@probot/adapter-aws-lambda-serverless" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
PR Overview
This pull request updates dependency versions and improves test cases in test.js. Key changes include:
- Adding a mock for API requests to verify emergency team membership.
- Simplifying error message assertions by checking only for "something awful happened".
- Updating assertions to verify that the emergency label is provided via requestBody.labels instead of an incorrect array index.
Changes
| File | Description |
|---|---|
| test.js | Updates test assertions and mocks to better reflect API payload structure and error messages |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
test.js:307
- The test case name contains a misspelling ('recieves'); consider correcting it to 'receives'.
test("recieves pull_request.labeled event, does nothing because not emergency label", async function () {
test.js:726
- [nitpick] The error message assertion has been simplified to match only 'something awful happened'. Ensure that eliminating the detailed context does not hinder future debugging.
assert.equal(err.errors[0][0].message, "something awful happened");
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to dependencies in the
package.jsonfile and several improvements and fixes to the test cases intest.js. The most important changes include updating dependencies to their latest versions, mocking API requests in tests, and simplifying error message assertions.