Merge pull request #37 from github/kh-fix-bug

bug: Fixes AvoidGenericLinkText bug

Author: khiga8

lib/erblint-github/linters/github/accessibility/avoid_generic_link_text_counter.rb

@@ -112,12 +112,17 @@ def autocorrect(processed_source, offense)
 
           private
 
+          # Downcase and strip punctuation and extra whitespaces.
+          def stripped_text(text)
+            text.downcase.gsub(/\W+/, " ").strip
+          end
+
           def banned_text?(text)
-            BANNED_GENERIC_TEXT.map(&:downcase).include?(text.downcase.gsub(/\W+/, " ").strip)
+            BANNED_GENERIC_TEXT.map(&:downcase).include?(stripped_text(text))
           end
 
           def valid_accessible_name?(aria_label, text)
-            aria_label.downcase.include?(text.downcase)
+            stripped_text(aria_label).include?(stripped_text(text))
           end
 
           def extract_ruby_node(source)

test/linters/accessibility/avoid_generic_link_text_counter_test.rb

@@ -82,7 +82,8 @@ def test_flags_when_aria_label_does_not_include_visible_link_text
 
   def test_does_not_flag_when_aria_label_includes_visible_link_text
     @file = <<~ERB
-      <a aria-label="Learn more about GitHub Sponsors">Learn more</a>
+      <a aria-label="Learn more about GitHub Sponsors.">Learn more.</a>
+      <a aria-label="Learn more about GitHub Sponsors.">Learn more  </a>
     ERB
     @linter.run(processed_source)