Skip to content

Update filenames #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 25, 2024
Merged

Update filenames #578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
15639d6
update filenames
gracepark Nov 25, 2024
c03d25b
bring in filenames match regex to github
gracepark Nov 25, 2024
7520260
add back in test examples;
gracepark Nov 25, 2024
725f1a1
bring in filenames to github rules
gracepark Nov 25, 2024
813592d
rule docs for filenames match regex
gracepark Nov 25, 2024
259194f
remove filenames plugin
gracepark Nov 25, 2024
a78d1ef
update items max and min
gracepark Nov 25, 2024
3116c0c
Update docs/rules/filenames-match-regex.md
gracepark Nov 25, 2024
e86d155
add comment
gracepark Nov 25, 2024
b5369f3
Merge remote-tracking branch 'refs/remotes/origin/filenames-fix' into…
gracepark Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = [
plugins: {
eslintPlugin,
importPlugin,
filenames,
filenamesPlugin: fixupPluginRules(filenames),
Copy link
Contributor

@arelia arelia Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it matter that it's not a string like 'i18n-text' on the next line?

Copy link
Contributor Author

@gracepark gracepark Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be okay - what I ended up doing was bringing in the filenames match regex rule into github. The filenames plugin is no longer supported and the compat utility was not working for our rule configuration.

'i18n-text': fixupPluginRules(i18nTextPlugin),
},
rules: {
Expand Down
6 changes: 6 additions & 0 deletions test-examples/flat/src/getAttribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,9 @@ const title = document.createElement('h1')
title.textContent = `${title}!`

foobar(title)

document.addEventListener('click', async function (event) {
const data = await fetch()

event.preventDefault()
})