Skip to content

Conversation

@chrheg
Copy link
Contributor

@chrheg chrheg commented Dec 11, 2024

Proposed Changes

This pull request includes several changes to the evergreen.py file, primarily focusing on renaming variables for clarity and improving the summary content generation.

Variable renaming and clarity improvements:

  • Renamed the variable project_id to project_global_id throughout the def main() function to improve clarity. [1] [2] [3]
  • Updated the link_item_to_project function to use project_global_id instead of project_id for consistency. [1] [2]

Summary content generation improvements:

  • Added newline character to the enable_security_updates summary item for better formatting.
  • Enhanced the summary content to include links directly in the table for issues and pull requests. [1] [2]# Pull Request

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@github-actions github-actions bot added the fix label Dec 11, 2024
@jmeridth jmeridth changed the title Fix/summary project output fix: summary project output Dec 11, 2024
@jmeridth
Copy link
Contributor

Linting error

evergreen.py:220:19: E0606: Possibly using variable 'project_global_id' before assignment (possibly-used-before-assignment)

@jmeridth
Copy link
Contributor

jmeridth commented Jan 5, 2025

@chrheg able to take a look at the linting issue?

@jmeridth jmeridth requested a review from a team as a code owner January 21, 2025 19:04
@jmeridth jmeridth enabled auto-merge (squash) January 21, 2025 19:04
@jmeridth jmeridth merged commit a69a6d3 into github:main Jan 21, 2025
6 checks passed
@chrheg chrheg deleted the fix/summary-project-output branch May 6, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants