Skip to content

Comments

Include change from stale PR, clean up topics-todo#4717

Merged
ahpook merged 4 commits intomainfrom
ahpook/misc-fixups
Apr 18, 2025
Merged

Include change from stale PR, clean up topics-todo#4717
ahpook merged 4 commits intomainfrom
ahpook/misc-fixups

Conversation

@ahpook
Copy link
Contributor

@ahpook ahpook commented Apr 18, 2025

  • Updated collection design-essentials to include open-props topic
  • Remove topics-todo and references to it

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

ahpook added 2 commits April 18, 2025 09:48
Change from contributor who didn't respond
Closes #4661
Effectively all those topics are now curated, so it's no longer
helpful to have the list sitting around. This commit removes it
and the references from the CONTIBUTING and README files as well.
Copilot AI review requested due to automatic review settings April 18, 2025 18:06
@ahpook ahpook requested a review from a team as a code owner April 18, 2025 18:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request cleans up stale references by removing the topics-todo file and updating related documentation while adding the "open-props" topic to the design-essentials collection.

  • Removed outdated topics-todo file.
  • Updated collections/design-essentials/index.md to include argyleink/open-props.
  • Cleaned up references to topics-todo from README.md and CONTRIBUTING.md.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
topics-todo.md Removed the obsolete topics-todo list.
collections/design-essentials/index.md Added the open-props topic to the collection.
README.md Removed the reference link to topics-todo.
CONTRIBUTING.md Removed the instruction to update topics-todo.

Copy link
Contributor

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs improvements ftw. and stale PR fix. Nice.

@ahpook ahpook enabled auto-merge April 18, 2025 18:15
@ahpook ahpook disabled auto-merge April 18, 2025 18:20
Copy link
Contributor

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be gone space. 😄

@ahpook ahpook added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit b4afce4 Apr 18, 2025
8 checks passed
@ahpook ahpook deleted the ahpook/misc-fixups branch April 18, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants