Skip to content

Support webp image format in isImage method #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khiga8
Copy link

@khiga8 khiga8 commented Aug 11, 2025

Unblocks https://github.com/github/github/pull/395413

Similar to #17, this PR adds image/webp to the list of accepted image types.

khiga8 added 2 commits August 11, 2025 17:30
Added 'image/webp' to the list of accepted image types.
@khiga8 khiga8 marked this pull request as ready for review August 11, 2025 21:37
@khiga8 khiga8 requested a review from a team as a code owner August 11, 2025 21:37
@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 21:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the WebP image format by including image/webp in the list of accepted MIME types for the isImage() method. This change enables WebP files to be properly recognized as images in the attachment handling system.

  • Added image/webp to the supported image MIME types array
  • Reformatted the return statement across multiple lines for better readability

@khiga8
Copy link
Author

khiga8 commented Aug 11, 2025

The failing looks like an unrelated failure with the CI setup 🤔
@github/primer-engineering can you assist?

@khiga8
Copy link
Author

khiga8 commented Aug 11, 2025

I would also love your assistance in releasing this new version when it's ready!
I can't find info in the docs 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants