-
Notifications
You must be signed in to change notification settings - Fork 19
feat(cli): add --agent-timeout flag for execution time limit #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e9cd2ac
feat(cli): add --agent-timeout flag for execution time limit
Mossaka 15a2e69
test: add unit tests for agent timeout in runAgentCommand
Mossaka f5ba3b4
test: add parseAgentTimeout tests to fix coverage regression
Mossaka 078ed8c
fix: resolve rebase conflicts and remove duplicate --tty flag
Mossaka db0912e
test: extract applyAgentTimeout for testable coverage
Mossaka ec3141c
test: add formatItem tests to fix coverage regression
Mossaka d646408
fix: clear timeout timer and use stricter validation
Mossaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,4 @@ | ||
| 2026-03-05: Task 002 - Fix minimatch ReDoS vulnerability. Ran `npm audit fix` to update minimatch from 10.2.1 to 10.2.4 and ajv to patched version. Build, tests (821 passed), and lint all pass. npm audit shows 0 vulnerabilities. Branch: fix/002-minimatch-redos-vuln. | ||
| PRIORITY: PR #1242 (task 025 - agent timeout) needs immediate attention. Has merge conflicts AND 3 Copilot review comments to address: (1) setTimeout not cleared/unrefed when docker wait completes normally - memory/timer leak, (2) parseInt accepts floats/negatives but flag is documented as 'positive integer' - needs stricter validation, (3) Missing test coverage for new timeout behavior in docker-manager.test.ts. Rebase onto main, resolve conflicts, fix all 3 review issues, then push. | ||
| PRIORITY: PR #1244 (task 055 - secure_getenv bypass) has integration test failures: Test Chroot Package Managers and agent smoke test. Investigate and fix. | ||
| PRIORITY: PR #1245 (task 103 - predownload images) has merge conflicts. Rebase onto main, resolve conflicts, push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds new timeout behavior in
runAgentCommand, butsrc/docker-manager.test.tsalready has unit tests for this function and none cover the timeout path (exit code 124 +docker stopcall + log streaming completion). Adding a focused test would help prevent regressions around the new race/stop logic.