Skip to content

fix: restore create-issue step and improve URL format in firewall-issue-dispatcher #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Apr 11, 2026
Merged

fix: restore create-issue step and improve URL format in firewall-issue-dispatcher #1910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67b9784
Initial plan
Copilot Apr 11, 2026
4b3574c
fix: restore create-issue step and improve URL format in dispatcher
Copilot Apr 11, 2026
6b92251
Merge branch 'main' into copilot/fix-code-comments-from-review
lpcox Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/firewall-issue-dispatcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,27 @@ gh api graphql -f query='

## Step 2: Filter Locally

For each issue found, read its comments and check whether any comment contains a reference to a `github/gh-aw-firewall` issue (i.e., a URL matching `https://github.com/github/gh-aw-firewall/issues/` or a GitHub cross-repo reference matching `github/gh-aw-firewall#`). If such a comment exists, **skip** that issue — it has already been audited.
For each issue found, read its comments and check whether any comment contains a reference to a `github/gh-aw-firewall` issue (i.e., a URL matching `https://github.com/github/gh-aw-firewall/issues/` or a GitHub cross-repo reference matching `github/gh-aw-firewall#`). If such a comment exists, **skip** that issue — it has already been audited. Do this filtering in your analysis — do NOT make additional API calls.
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions reverting the cron minute in firewall-issue-dispatcher.lock.yml back to 11 */6 * * *, but the lock file currently still has cron: "20 */6 * * *" (see .github/workflows/firewall-issue-dispatcher.lock.yml:42). Please update the lock workflow schedule if the 20 minute value was unintended.

Copilot uses AI. Check for mistakes.

If no unprocessed issues remain, call `noop` and stop.

## Step 3: Create Tracking Issues

For each **unprocessed** issue:

4. **Comment on the original `github/gh-aw` issue** linking to the newly created tracking issue. Use this exact format:
1. **Create a tracking issue in `github/gh-aw-firewall`** using the `create_issue` safe output with:
- Title: `[awf] <component>: <summary>`
- Body: **Problem**, **Context** (link to original), **Root Cause**, **Proposed Solution**
- Labels: `awf-triage`
- Reference specific source files. See `AGENTS.md` for component descriptions.

2. **Comment on the original `github/gh-aw` issue** linking to the newly created tracking issue. Use this exact format:
> 🔗 AWF tracking issue: https://github.com/github/gh-aw-firewall/issues/{NUMBER}

where `{NUMBER}` is replaced with **only the numeric issue number** (e.g., `1896`). Do NOT include the repository name, hash symbols, or any other text — just the number in the URL path. Use the `add_comment` safe output tool with `repo: "github/gh-aw"` and the original issue number.

where `{NUMBER}` is replaced with **only the numeric issue number** (e.g., `1896`). Do NOT include the repository name, hash symbols, or any other text — just the number in the URL path. Use the `add_comment` safe output tool with `repo: "github/gh-aw"` and the original issue number.

Comment on lines +87 to +88
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The {NUMBER} substitution guidance paragraph is duplicated back-to-back, which adds noise and can confuse the agent. Remove the duplicate paragraph so the instructions appear only once.

Suggested change
where `{NUMBER}` is replaced with **only the numeric issue number** (e.g., `1896`). Do NOT include the repository name, hash symbols, or any other text — just the number in the URL path. Use the `add_comment` safe output tool with `repo: "github/gh-aw"` and the original issue number.

Copilot uses AI. Check for mistakes.
### 4. Report Results

Report: issues found, skipped (already audited), tracking issues created.
Expand Down
Loading