Issue analysis: Secret Scanning alert resolver name feature already implemented

[Copilot]

After analyzing issue #1334, I found that the requested feature to include the original resolver name in migrated Secret Scanning alerts has already been implemented and is working correctly.

Current Implementation

The SecretScanningAlertService.cs already includes the functionality at line 77:

var targetResolutionComment = $"[@{sourceAlert.Alert.ResolverName}] {sourceAlert.Alert.ResolutionComment}";

This implementation:

• ✅ Copies the resolver name from the original alert
• ✅ Formats it as [@actorname] original comment as requested
• ✅ Preserves information about who originally closed an alert
• ✅ Works even when migration is performed by a GitHub App

Verification

• Feature is documented in release notes v1.9.1.md
• All 18 existing tests pass and verify the correct behavior
• Multiple test cases validate the format including edge cases (null comments)

Example Output

When migrating an alert originally resolved by @theztefan with comment "Revoked today", the target alert will have:

• Resolver: ghas-control[bot] (the GitHub App)
• Comment: [@theztefan] Revoked today

This matches exactly what was requested in the issue description.

Fixes #1334.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• http://www.microsoft.com:80/pkiops/crl/Microsoft%20Identity%20Verification%20Root%20Certificate%20Authority%202020.crl
  • Triggering command: dotnet test OctoshiftCLI.Tests/OctoshiftCLI.Tests.csproj --filter SecretScanningAlertServiceTests --logger console;verbosity=minimal (http block)
• http://www.microsoft.com:80/pkiops/crl/Microsoft%20Public%20RSA%20Timestamping%20CA%202020.crl
  • Triggering command: dotnet test OctoshiftCLI.Tests/OctoshiftCLI.Tests.csproj --filter SecretScanningAlertServiceTests --logger console;verbosity=minimal (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[dylan-smith]

Good job copilot, you are correct!