Fix whitespace formatting errors and CI coverage file handling #1355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI build failures caused by:
Changes Made
🔧 Fixed whitespace indentation in
src/Octoshift/Services/AdoApi.csChanged indentation of
allow = 0anddeny = 56828properties from 20 spaces to 8 spaces for consistency with CodeQL requirements:new { descriptor = identityDescriptor, - allow = 0, - deny = 56828, + allow = 0, + deny = 56828, extendedInfo = new🛠️ Made CI coverage file copy more robust in
.github/workflows/CI.ymlAdded conditional check to prevent workflow failures when coverage files don't exist:
- name: Copy Coverage To Predictable Location if: always() && matrix.runner-os == 'ubuntu-latest' - run: cp coverage/**/coverage.cobertura.xml coverage/coverage.cobertura.xml + run: | + if ls coverage/**/coverage.cobertura.xml 1> /dev/null 2>&1; then + cp coverage/**/coverage.cobertura.xml coverage/coverage.cobertura.xml + else + echo "No coverage file found, skipping copy" + fiVerification
dotnet builddotnet format --verify-no-changesvalidationThese changes resolve the CodeQL whitespace formatting issues and make the CI workflow more resilient to missing coverage files.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
http://www.microsoft.com:80/pkiops/crl/Microsoft%20Identity%20Verification%20Root%20Certificate%20Authority%202020.crldotnet restore /home/REDACTED/work/gh-gei/gh-gei/src/OctoshiftCLI.sln(http block)http://www.microsoft.com:80/pkiops/crl/Microsoft%20Public%20RSA%20Timestamping%20CA%202020.crldotnet restore /home/REDACTED/work/gh-gei/gh-gei/src/OctoshiftCLI.sln(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.