Add workflow permissions and a SHA argument to Integration Test Build #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security for the Integration Tests workflow by adding explicit permissions and verifying the PR head SHA.
- Added a required
shainput to the workflow dispatch. - Introduced a
permissionsblock with least-privilege settings. - Added a “Check SHA” step to validate the provided SHA matches the PR head.
Comments suppressed due to low confidence (3)
.github/workflows/integration-tests.yml:9
- Input name is defined as
sha(lowercase) but later referenced as${{ github.event.inputs.SHA }}(uppercase). This mismatch means the check will always compare against an empty value—use${{ github.event.inputs.sha }}consistently.
sha:
.github/workflows/integration-tests.yml:31
- The
runblock mixes Bash syntax (backticks) with PowerShell commands (Write-Output,if ($...)). Specifyshell: bashor convert fully to PowerShell to ensure commands execute correctly.
- name: Check SHA
.github/workflows/integration-tests.yml:33
- [nitpick] Rather than invoking
git rev-parse, consider using${{ github.event.inputs.sha }}orgithub.event.pull_request.head.shadirectly from the GitHub context to simplify the workflow.
prsha=`git rev-parse origin/pull/${{ github.event.inputs.pr_number }}/head | awk '{ print $1 }'`
Unit Test Results 1 files 1 suites 21s ⏱️ Results for commit d410a25. ♻️ This comment has been updated with latest results. |
dpmex4527
approved these changes
Jun 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the security of the
Integration Testsbuild I added explicit workflow permissions, and I required the person who queues it to specify the SHA of the PR in addition to the PR number.ThirdPartyNotices.txt(if applicable)