Conversation
…lts workflow Fix code scanning alert for environment variable injection by correcting the tr command to properly sanitize PR_NUMBER. Changed from tr -cd '[0-9]' to tr -cd '0-9' to ensure only digits are allowed, preventing potential injection attacks from user-controlled workflow_run events.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the character class syntax in a GitHub workflow that extracts PR numbers from event data. The original code incorrectly treated square brackets as literal characters rather than range delimiters.
- Corrected the
trcommand to use proper range syntax'0-9'instead of'[0-9]'
Unit Test Results 1 files 1 suites 10m 24s ⏱️ Results for commit 817ff79. ♻️ This comment has been updated with latest results. |
|
mulana
deleted the
mulana/security-issue-environment-variable-injection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves code scanning alert #1035 - Environment variable injection in
publish-test-results.ymlworkflow by correcting the tr command to properly sanitize PR_NUMBER. Changed fromtr -cd '[0-9]'totr -cd '0-9'to ensure only digits are allowed, preventing potential injection attacks from user-controlled workflow_run events.ThirdPartyNotices.txt(if applicable)