[Copy of 1460] Add path validation and logging for bbs2gh archive operations #1462
Merged
[Copy of 1460] Add path validation and logging for bbs2gh archive operations #1462
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds early validation for file system paths used in the bbs2gh migrate-repo command to fail fast with clear error messages, and adds logging of the archive path before upload operations to aid troubleshooting.
- Added validation to check that
--archive-pathexists before attempting to use it - Added validation to check that
--bbs-shared-homeexists when running on a Bitbucket instance (not using SSH/SMB download) - Added logging of the archive path before upload operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandHandler.cs | Added validation logic for archive-path and bbs-shared-home options, and added logging of archive path before upload operations |
| src/Octoshift/Services/FileSystemProvider.cs | Added DirectoryExists method to support directory validation |
| src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs | Added comprehensive test coverage for the new validation logic and logging, including tests for SSH/SMB scenarios where validation should be skipped |
| RELEASENOTES.md | Updated with user-friendly description of the new validation and logging features |
6 tasks
Unit Test Results 1 files 1 suites 10m 24s ⏱️ Results for commit e5a536a. ♻️ This comment has been updated with latest results. |
|
brianaj
changed the title
jfine
approved these changes
Dec 3, 2025
Contributor
jfine
left a comment
jfine
left a comment
There was a problem hiding this comment.
I didn't directly excersise the code however it looks ✨.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ship changes in #1460
Fixes #1211
ThirdPartyNotices.txt(if applicable)