Additional test

timvaillancourt · timvaillancourt · commit e5f7b6beec2a · 2022-12-13T01:06:36.000+01:00
diff --git a/go/base/utils_test.go b/go/base/utils_test.go
@@ -86,6 +86,14 @@ func TestValidateConnection(t *testing.T) {
 		}
 		test.S(t).ExpectNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
 	}
+	// check validation fails when port does not match connectionConfig
+	{
+		migrationContext := &MigrationContext{Log: NewDefaultLogger()}
+		serverInfo := &mysql.ServerInfo{
+			Port: gosql.NullInt64{Int64: 9999, Valid: true},
+		}
+		test.S(t).ExpectNotNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
+	}
 	// check validation fails when port and extra_port are invalid
 	{
 		migrationContext := &MigrationContext{Log: NewDefaultLogger()}

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,14 @@ func TestValidateConnection(t *testing.T) {`
`86`	`86`	`}`
`87`	`87`	`test.S(t).ExpectNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))`
`88`	`88`	`}`
	`89`	`+ // check validation fails when port does not match connectionConfig`
	`90`	`+ {`
	`91`	`+ migrationContext := &MigrationContext{Log: NewDefaultLogger()}`
	`92`	`+ serverInfo := &mysql.ServerInfo{`
	`93`	`+ Port: gosql.NullInt64{Int64: 9999, Valid: true},`
	`94`	`+ }`
	`95`	`+ test.S(t).ExpectNotNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))`
	`96`	`+ }`
`89`	`97`	`// check validation fails when port and extra_port are invalid`
`90`	`98`	`{`
`91`	`99`	`migrationContext := &MigrationContext{Log: NewDefaultLogger()}`