Skip to content

Conversation

shlomi-noach
Copy link
Contributor

Resubmission of openark#23 from downstream

Fixes #991

gh-ost will fail with error when -switch-to-rbr is provided and when running directly on primary (--allow-on-master).

Low risk

No changes to migration logic, just added command line validation

Support a complete ALTER TABLE statement in --alter
Initial commit: towards setting up a test suite

Signed-off-by: Shlomi Noach <[email protected]>
…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Copying AUTO_INCREMENT value to ghost table
Generated column as part of UNIQUE (or PRIMARY) KEY
Cut-over should wait for heartbeat lag to be low enough to succeed
All MySQL DBs limited to max 3 concurrent/idle connections
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
hooks: reporting GH_OST_ETA_SECONDS. ETA as part of migration context
@timvaillancourt timvaillancourt added this to the v1.1.5 milestone Jun 2, 2022
@timvaillancourt timvaillancourt self-requested a review June 2, 2022 22:40
timvaillancourt
timvaillancourt previously approved these changes Jun 2, 2022
Copy link
Collaborator

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋/:pray: @shlomi-noach, sorry for the delay!

LGTM once this is rebased 👍. Currently can't merge

ghost
ghost previously approved these changes Jul 6, 2022
@ghost ghost modified the milestones: v1.1.5, v1.1.6 Jul 6, 2022
@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Aug 21, 2022

The golangci-lint test fails, with what seems like useless output?

2022-08-21T05:54:12.7308332Z ##[group]run golangci-lint
2022-08-21T05:54:12.7312245Z Running [/home/runner/golangci-lint-1.46.2-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
2022-08-21T05:54:26.8253755Z ##[error]unnecessary trailing newline (whitespace)
2022-08-21T05:54:26.8266486Z ##[error]unnecessary trailing newline (whitespace)
2022-08-21T05:54:26.8267648Z ##[error]unnecessary trailing newline (whitespace)
2022-08-21T05:54:26.8268825Z ##[error]S1011: should replace loop with `result.columns = append(result.columns, columns1.Columns()...)` (gosimple)
2022-08-21T05:54:26.8270059Z ##[error]S1011: should replace loop with `result.columns = append(result.columns, columns2.Columns()...)` (gosimple)

I'm actually unable to find where exactly the linter sees the issue?

@timvaillancourt
Copy link
Collaborator

timvaillancourt commented Aug 21, 2022

I'm actually unable to find where exactly the linter sees the issue?

@shlomi-noach thanks! Yikes, that output isn't so useful 🤔

This check-annotations page has much more useful output and clicking on each nit jumps to the code (TIL 🚀): https://github.com/github/gh-ost/actions/runs/2897390310. It looks like it's mad about some extra whitespace and 2 x loops that could be simplified to append(something, other...) 👍

@timvaillancourt timvaillancourt dismissed stale reviews from ghost and themself via e7d9342 October 21, 2022 15:47
@timvaillancourt timvaillancourt modified the milestones: v1.1.6, v1.1.7 Dec 7, 2023
@meiji163 meiji163 modified the milestones: v1.1.7, v1.1.8 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - switching to row based replication and data loss
4 participants