Rename to error on unknown

Author: omgitsads

pkg/toolsets/toolsets.go

@@ -204,13 +204,13 @@ func (tg *ToolsetGroup) IsEnabled(name string) bool {
 }
 
 type EnableToolsetsOptions struct {
-	IgnoreUnknown bool
+	ErrorOnUnknown bool
 }
 
 func (tg *ToolsetGroup) EnableToolsets(names []string, options *EnableToolsetsOptions) error {
 	if options == nil {
 		options = &EnableToolsetsOptions{
-			IgnoreUnknown: true,
+			ErrorOnUnknown: false,
 		}
 	}
 
@@ -221,15 +221,15 @@ func (tg *ToolsetGroup) EnableToolsets(names []string, options *EnableToolsetsOp
 			break
 		}
 		err := tg.EnableToolset(name)
-		if err != nil && !options.IgnoreUnknown {
+		if err != nil && options.ErrorOnUnknown {
 			return err
 		}
 	}
 	// Do this after to ensure all toolsets are enabled if "all" is present anywhere in list
 	if tg.everythingOn {
 		for name := range tg.Toolsets {
 			err := tg.EnableToolset(name)
-			if err != nil && !options.IgnoreUnknown {
+			if err != nil && options.ErrorOnUnknown {
 				return err
 			}
 		}

pkg/toolsets/toolsets_test.go

@@ -154,13 +154,13 @@ func TestEnableToolsets(t *testing.T) {
 	}
 
 	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{
-		IgnoreUnknown: true,
+		ErrorOnUnknown: false,
 	})
 	if err != nil {
 		t.Errorf("Expected no error when ignoring unknown toolsets, got: %v", err)
 	}
 
-	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{IgnoreUnknown: false})
+	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{ErrorOnUnknown: true})
 	if err == nil {
 		t.Error("Expected error when enabling list with non-existent toolset")
 	}