Skip to content

Add return ID to CRUD tools #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2025
Merged

Add return ID to CRUD tools #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f4ab33
add return ID to crud tools
mattdholloway Sep 10, 2025
634b323
Update pkg/github/gists.go
mattdholloway Sep 10, 2025
022c951
Update pkg/github/gists.go
mattdholloway Sep 10, 2025
33c689b
fix gist id to string conv
mattdholloway Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/github/gists.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ func CreateGist(getClient GetClientFn, t translations.TranslationHelperFunc) (to
}

minimalResponse := MinimalResponse{
ID: createdGist.GetID(),
URL: createdGist.GetHTMLURL(),
}

Expand Down Expand Up @@ -254,6 +255,7 @@ func UpdateGist(getClient GetClientFn, t translations.TranslationHelperFunc) (to
}

minimalResponse := MinimalResponse{
ID: updatedGist.GetID(),
URL: updatedGist.GetHTMLURL(),
}

Expand Down
2 changes: 2 additions & 0 deletions pkg/github/issues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,7 @@ func CreateIssue(getClient GetClientFn, t translations.TranslationHelperFunc) (t

// Return minimal response with just essential information
minimalResponse := MinimalResponse{
ID: fmt.Sprintf("%d", issue.GetID()),
URL: issue.GetHTMLURL(),
}

Expand Down Expand Up @@ -1249,6 +1250,7 @@ func UpdateIssue(getClient GetClientFn, t translations.TranslationHelperFunc) (t

// Return minimal response with just essential information
minimalResponse := MinimalResponse{
ID: fmt.Sprintf("%d", updatedIssue.GetID()),
URL: updatedIssue.GetHTMLURL(),
}

Expand Down
1 change: 1 addition & 0 deletions pkg/github/minimal_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ type MinimalBranch struct {
// Success is implicit in the HTTP response status, and all other information
// can be derived from the URL or fetched separately if needed.
type MinimalResponse struct {
ID string `json:"id"`
URL string `json:"url"`
}

Expand Down
2 changes: 2 additions & 0 deletions pkg/github/pullrequests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ func CreatePullRequest(getClient GetClientFn, t translations.TranslationHelperFu

// Return minimal response with just essential information
minimalResponse := MinimalResponse{
ID: fmt.Sprintf("%d", pr.GetID()),
URL: pr.GetHTMLURL(),
}

Expand Down Expand Up @@ -471,6 +472,7 @@ func UpdatePullRequest(getClient GetClientFn, getGQLClient GetGQLClientFn, t tra

// Return minimal response with just essential information
minimalResponse := MinimalResponse{
ID: fmt.Sprintf("%d", finalPR.GetID()),
URL: finalPR.GetHTMLURL(),
}

Expand Down
2 changes: 2 additions & 0 deletions pkg/github/repositories.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,7 @@ func CreateRepository(getClient GetClientFn, t translations.TranslationHelperFun

// Return minimal response with just essential information
minimalResponse := MinimalResponse{
ID: fmt.Sprintf("%d", createdRepo.GetID()),
URL: createdRepo.GetHTMLURL(),
}

Expand Down Expand Up @@ -744,6 +745,7 @@ func ForkRepository(getClient GetClientFn, t translations.TranslationHelperFunc)

// Return minimal response with just essential information
minimalResponse := MinimalResponse{
ID: fmt.Sprintf("%d", forkedRepo.GetID()),
URL: forkedRepo.GetHTMLURL(),
}

Expand Down
Loading