-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update MCP Registry Publish Script #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c04f40d
Add publish script and formed server file
MattBabbage b632d56
Fix url and fix script
MattBabbage 5802130
Set version to 0.0.0 initially
MattBabbage dccbde3
remove uncessary script
MattBabbage c3c10cd
remove unnecessary ignore
MattBabbage e6bc1d7
Remove whitespace
MattBabbage 22740ce
Apply suggestion from @Copilot
MattBabbage 94a4937
Add registry publisher workflow
MattBabbage 1ce3281
Fetch tags in registry release workflow
MattBabbage 842fc6f
Update registry workflow and server.json with VERSION placeholder
MattBabbage 7dac132
Merge main into matt/publish-to-mcp-registry branch, keeping our regi…
MattBabbage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,13 +7,13 @@ | |
| "url": "https://github.com/github/github-mcp-server", | ||
| "source": "github" | ||
| }, | ||
| "version": "0.0.0", | ||
| "version": "${VERSION}", | ||
| "packages": [ | ||
| { | ||
| "registryType": "oci", | ||
| "registryBaseUrl": "https://ghcr.io", | ||
| "identifier": "ghcr.io/github/github-mcp-server", | ||
| "version": "0.0.0", | ||
| "version": "${VERSION}", | ||
|
Comment on lines
+10
to
+16
|
||
| "runtimeHint": "docker", | ||
| "transport": { | ||
| "type": "stdio" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using shell variable syntax
${VERSION}in a JSON file creates an invalid JSON document. Consider using a different placeholder format like__VERSION__or{{VERSION}}to maintain JSON validity while the file serves as a template.See below for a potential fix: