Skip to content

Conversation

marzvrover
Copy link
Member

@marzvrover marzvrover commented Oct 15, 2025

Adds a gemini-extension.json manifest file so that the remote MCP server can be installed with the gemini extensions install https://github.com/github/github-mcp-server command.

Also updates the env var name for the PAT in all Gemini CLI cases to be GITHUB_MCP_PAT. Gemini CLI uses environment variables plus those found in the .env file, so I caution using a more explicitly named variable to prevent a user accidentally using a PAT they have in their environment that contains permissions that they may not want their MCP instance to have access to.

@marzvrover marzvrover marked this pull request as ready for review October 15, 2025 20:49
@marzvrover marzvrover requested a review from a team as a code owner October 15, 2025 20:49
@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 20:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for installing the GitHub MCP server via Gemini CLI's extension system and standardizes environment variable naming for better security. The changes introduce a gemini-extension.json manifest file that enables one-command installation and updates all documentation to use the more explicit GITHUB_MCP_PAT environment variable name instead of the generic GITHUB_PAT.

  • Added gemini-extension.json manifest file for Gemini CLI extension support
  • Updated environment variable name from GITHUB_PAT to GITHUB_MCP_PAT across all installation methods
  • Simplified installation documentation to recommend the new extension-based approach

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
gemini-extension.json New manifest file defining the GitHub MCP server extension configuration
docs/installation-guides/install-gemini-cli.md Updated to use new env var name and recommend extension installation method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -0,0 +1,12 @@
{
"name": "github",
"version": "1.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a description pls?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect AI assistants to GitHub - manage repos, issues, PRs, and workflows through natural language. is the description we use for the registry can we stick to the same description here too.


> **Note:** For the most up-to-date configuration options, see the [main README.md](../../README.md).
### Method 1: Remote Server (Recommended)
Copy link
Contributor

@tonytrg tonytrg Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we turn that into two seperate methods.
Id prefer not to delete the manual instruction, as there are prob some people who like to configure it themselves

Method 1: Extension (Recommended)

...

Method 2: Manual config

@tonytrg
Copy link
Contributor

tonytrg commented Oct 16, 2025

left some comments, but tested the flow and it works nicely great stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants