Skip to content

Clarify create_pull_request_review input schema definition for: 'position' #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamipouchi wants to merge 1 commit into from
Closed

Clarify create_pull_request_review input schema definition for: 'position' #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/github/pullrequests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,9 @@ func createPullRequestReview(client *github.Client, t translations.TranslationHe
"description": "path to the file",
},
"position": map[string]interface{}{
"type": "number",
"description": "line number in the file",
"type": "number",
"description": `number of lines down from the first "@@" hunk header in the diff. The line just below the "@@" line is position 1, the next line is position 2, and so on. The position in the diff continues to increase through lines of whitespace and additional hunks.
This value is not the same as the line number in the file.`,
},
"body": map[string]interface{}{
"type": "string",
Expand Down