Skip to content

Conversation

@aryasoni98
Copy link
Contributor

Closes: #141

Copilot AI review requested due to automatic review settings April 7, 2025 10:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank so much for opening this PR! 🚀

A couple of things if you don't mind:

  • Could you please update the README with the new supported tool
  • Re: pagination, please take a look at #137 which we have just merged and changed a bit how we handle pagination. If you could adopt that way of handling pagination in this PR, it'd be really great.

Thank you!

@aryasoni98
Copy link
Contributor Author

Thank so much for opening this PR! 🚀

A couple of things if you don't mind:

  • Could you please update the README with the new supported tool
  • Re: pagination, please take a look at pkg/github: fix use of per page parameter #137 which we have just merged and changed a bit how we handle pagination. If you could adopt that way of handling pagination in this PR, it'd be really great.

Thank you!

Thank you for the review! I've addressed both points:

  1. Added the list_branches tool documentation to the README under the Repository section, including all parameters and their descriptions.

  2. Updated the pagination handling to use withPagination() helper function instead of direct parameter definitions, matching the approach used in PR pkg/github: fix use of per page parameter #137. The changes include:

    • Removed explicit page and perPage parameter definitions
    • Added withPagination() to the tool definition
    • Updated the handler to use optionalPaginationParams for parameter extraction

All tests are passing and the code is now consistent with the project's pagination handling standards. Let me know if you'd like me to make any additional adjustments!

@aryasoni98 aryasoni98 requested a review from juruen April 7, 2025 21:50
Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the back and forth! But would you capitalizing the new tool to be consistent with the main?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to view "branches" for a repo

2 participants